Skip to content

Add lvm vg properties for lvm2app.

Dave Wysochanski lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12Add vg_attr() and lv_attr() functions.lib/metadata/metadata.c lib/metadata/metadata.h lib/report/report.c+175 -1552 replies
2/12Refactor pvstatus_disp to take pv argument and call common pv_attr function.lib/metadata/metadata.c lib/metadata/metadata.h lib/report/columns.h +1 more+26 -150 replies
3/12Add id_format_and_copy() uuid function to allocate and format a uuid.lib/uuid/uuid.c lib/uuid/uuid.h+17 -01 reply
3/12Add id_format_and_copy() uuid function to allocate and format a uuid.+0 -00 replies
4/12Call id_format_and_copy from _uuid_disp.lib/report/report.c+1 -60 replies
5/12Add pv_uuid, vg_uuid, and lv_uuid, and call id_format_and_copy.lib/metadata/metadata.c lib/metadata/metadata.h liblvm/lvm_lv.c +2 more+23 -231 reply
5/12Add pv_uuid, vg_uuid, and lv_uuid, and call id_format_and_copy.+0 -00 replies
6/12Add tags_format_and_copy() common function to format tags strings.lib/metadata/metadata.c lib/metadata/metadata.h lib/report/report.c+28 -180 replies
7/12Add pv_tags, vg_tags, lv_tags functions that call tags_format_and_copy.lib/metadata/metadata.c lib/metadata/metadata.h+18 -00 replies
8/12Add GET_STR_PROPERTY_FN macro.lib/report/properties.c+9 -00 replies
9/12Add 'get' functions for a few vg string fields, vg_name, vg_fmt, vg_sysid.lib/report/properties.c+20 -30 replies
10/12Add vg_uuid, vg_attr, vg_tags 'get' functions.lib/report/properties.c+3 -30 replies
11/12Add lvm_vg_get_property() generic vg property function.liblvm/lvm2app.h liblvm/lvm_vg.c+61 -00 replies
12/12Add tests for lvm_vg_get_property().test/api/test.c+33 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] Add lvm vg properties for lvm2app.

This patchset is a continuation of the prior patchset to implement generic functions to query a value of a field in an lvm report. This patchset completes the vg-based fields of the report and adds a generic function, lvm_vg_get_property() to lvm2app to query the properties by name.

For the string-based properties, memory allocation is done inside the individual supporting functions (i.e. vg_name(), vg_uuid(), etc). I decided this to be the best approach for consistency sake, and since some of the properties (for example, vg_attr, and vg_uuid) required special formatting and thus required the allocation to be done at the lower level.

I'm not entirely happy with this patchset but it is close enough. In particular, some of the functions might be better placed inside a separate file in lib/report and then shared between report.c and properties.c. For now I've placed most of the functions inside metadata.c.

Once this patchset is accepted and committed, I shall continue with the pv and lv properties using the same approach.