Skip to content

tcm/tcm_loop: Add BIDI-COMMAND support

Nicholas A. Bellinger linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 4 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tcm: Add support for BIDI-COMMANDS and XDWRITE_READ_10 emulationdrivers/target/target_core_pr.c drivers/target/target_core_transport.c include/target/target_core_base.h +1 more+254 -473 replies
1/2tcm: Add support for BIDI operation and XDWRITE_READ_10 emulationdrivers/target/target_core_pr.c drivers/target/target_core_transport.c include/target/target_core_base.h +1 more+254 -471 reply
2/2tcm_loop: Add BIDI-COMMAND CDB supportdrivers/target/tcm_loop/tcm_loop_fabric_scsi.c+34 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] tcm/tcm_loop: Add BIDI-COMMAND support

From: Nicholas Bellinger <[email protected]>

Greetings Boaz and Co,

This is the rebased TCM Core + TCM_Loop module BIDI-COMMAND v2 patch series to address Boaz's comments about the proper usage of DMA_BIDIRECTIONAL within TCM Core and TCM_Loop and his other points. I have already pushed the follow up patches into lio-core-2.6.git/lio-4.0, and this is a follow up series for Boaz to add comments w/o the original incorrect DMA_BIDIRECTIONAL usage in the v1 code.

So far this has been tested with the same custom XDWRITE_READ_10 BSG userspace code as the v1 patch and things are functioning as expected so far. I will also be testing with an BIDI capable sg_raw patch from Doug Gilbert. (Thanks Doug!)

Many thank go to Boaz for sharing his knowledge of BIDI for adding proper support into TCM Core and TCM_Loop code!

Best,

Nicholas Bellinger (2):
tcm: Add support for BIDI-COMMANDS and XDWRITE_READ_10 emulation
tcm_loop: Add BIDI-COMMAND CDB support

 drivers/target/target_core_pr.c                |    3 +-
 drivers/target/target_core_transport.c         |  278 ++++++++++++++++++++----
 drivers/target/tcm_loop/tcm_loop_fabric_scsi.c |   47 +++-
 include/target/target_core_base.h              |   10 +-
 include/target/target_core_transport.h         |   10 +-
 5 files changed, 288 insertions(+), 60 deletions(-)