Skip to content

Switch ads7846 driver to use soft irq

Jason Wang linux-input linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Input: ads7846 - switch to using threaded IRQdrivers/input/touchscreen/ads7846.c+446 -4300 replies
2/4Input: ads7846 - add a include header to prevent building failsdrivers/input/touchscreen/ads7846.c+1 -00 replies
3/4Input: ads7846 - restore ADC to powerdown mode if no messgaes neededdrivers/input/touchscreen/ads7846.c+4 -10 replies
4/4Input: ads7846 - modificatons of _stop()/_disable() conditionsdrivers/input/touchscreen/ads7846.c+5 -813 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchGrazvydas IgnotasTony Lindgren
1/4
2/4
3/4
4/4T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Switch ads7846 driver to use soft irq

Some explanations:

The first patch is from dmitry, he build a frame work for this driver to use soft irq. The remaining 3 patches are from me to fix some issues for the driver of soft irq verison.

We change this driver to use soft irq because under current version, we must use spin lock to protect racing issues, the regulator operations are also in the racing issue list but we can't put it in the spin lock protected area because regulator operations always implement via i2c/spi transfers, in those transfers often call sleep funcitons. Now change to use soft irq, we can use mutex instread of spin lock, so this issue is solved.

I have tested these patches on the ti_omap3530evm board:
1)use ts_lib after normal boot
2)use ts_lib after "#echo 1/0 > /sys/bus/spi/devices/spi0.1/disable" 3)use ts_lib after "#echo mem > /sys/power/state" and "wake up"