Skip to content

qcow2: Save another common flush

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4qcow2: Move sync out of write_refcount_block_entriesblock/qcow2-refcount.c+3 -10 replies
2/4qcow2: Move sync out of update_refcountblock/qcow2-refcount.c+11 -22 replies
3/4qcow2: Move sync out of qcow2_alloc_clustersblock/qcow2-cluster.c block/qcow2-refcount.c block/qcow2-snapshot.c+7 -20 replies
4/4qcow2: Get rid of additional sync on COWblock/qcow2-cluster.c+8 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] qcow2: Save another common flush

For copy on write (this includes any cluster allocations that don't fill the whole cluster with one request), what qcow2 does looks like this:

1. Allocate new clusters (increase refcounts)
2. bdrv_flush
3. Copy sectors before the first touched one
4. bdrv_flush
5. Copy sectors after the last touched one
6. bdrv_flush
7. Update the L2 table to point to the new clusters

Step 2 and 4 are not necessary. This series moves flushes around to get all of these three bdrv_flush calls merged into one.

Kevin Wolf (4):
qcow2: Move sync out of write_refcount_block_entries
qcow2: Move sync out of update_refcount
qcow2: Move sync out of qcow2_alloc_clusters
qcow2: Get rid of additional sync on COW

 block/qcow2-cluster.c  |   11 ++++++++++-
 block/qcow2-refcount.c |   13 ++++++++++++-
 block/qcow2-snapshot.c |    2 ++
 3 files changed, 24 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.2.2