Skip to content

cifs: multiuser mount overhaul (try #4)

Jeff Layton linux-cifs linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 of 15 patches 6 repliesIn review

12 of 15 patches are in this archive. The cover letter announces 15.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15cifs: add tcon field to cifsFileInfo structfs/cifs/cifsglob.h fs/cifs/dir.c+2 -00 replies
2/15cifs: make various routines use the cifsFileInfo->tcon pointerfs/cifs/cifsfs.c fs/cifs/file.c fs/cifs/inode.c +2 more+45 -560 replies
4/15cifs: add function to get a tcon from cifs_sbfs/cifs/cifs_dfs_ref.c fs/cifs/cifsacl.c fs/cifs/cifsfs.c +10 more+74 -710 replies
5/15cifs: temporarily rename cifs_sb->tcon to ptcon to catch stragglersfs/cifs/cifs_fs_sb.h fs/cifs/cifsglob.h fs/cifs/connect.c+4 -40 replies
7/15cifs: have cifs_new_fileinfo take a tcon argfs/cifs/cifsproto.h fs/cifs/dir.c fs/cifs/file.c+16 -140 replies
8/15cifs: add refcounted and timestamped container for holding tconsfs/cifs/cifs_dfs_ref.c fs/cifs/cifsacl.c fs/cifs/cifsglob.h +6 more+365 -1370 replies
9/15cifs: have cifsFileInfo hold a reference to a tlink rather than tcon pointerfs/cifs/cifsfs.c fs/cifs/cifsglob.h fs/cifs/cifsproto.h +6 more+59 -513 replies
10/15cifs: have find_readable/writable_file filter by fsuidfs/cifs/cifs_fs_sb.h fs/cifs/cifsacl.c fs/cifs/cifsproto.h +3 more+33 -151 reply
12/15cifs: add routines to build sessions and tcons on the flyfs/cifs/cifs_fs_sb.h fs/cifs/cifsglob.h fs/cifs/connect.c+281 -280 replies
13/15cifs: on multiuser mount, set ownership to current_fsuid/current_fsgidfs/cifs/inode.c+8 -02 replies
14/15cifs: add "multiuser" mount optionfs/cifs/connect.c+13 -00 replies
15/15cifs: implement recurring workqueue job to prune old tconsfs/cifs/cifs_fs_sb.h fs/cifs/connect.c+58 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] cifs: multiuser mount overhaul (try #4)

This is the fourth attempt at a patchset to overhaul the multiuser CIFS mount capability in the kernel. The main difference from the last is the addition of a recurring workqueue job to close out idle tcons (Tree Connects). The patchset has also been rebased on top of a very recent pull of Steve's tree including the patches from Metze to implement mfsymlinks.

Many people may be aware that CIFS has a MultiuserMount switch in /proc/fs/cifs. This code basically works, but it has a number of shortcomings that make it impractical to deploy. This patchset is
a redesign of that concept from scratch that allows CIFS to use multiple sessions to the same server, establish them on an as-needed basis and tear them down when they've been idle for a period of time.

Because we cannot prompt for passwords from the kernel, this code is currently limited to using krb5 authentication. Igor Druzhinin has done some work as a Google Summer of Code project to allow the stashing of username/password in the kernel keyring. Once that code is ready, we'll be able to extend this to other sec= types as well.

The patchset is large, but I've done my best to split it up into a logical set of bisectable changes. Some of the patches touch the same areas of code as earlier ones. This increases the amount of "churn" but I think it makes a more logical sequence of changes.

At this point, I think this code is ready for merge. I'd like to see it in 2.6.37. Comments and review are welcome.

Jeff Layton (15):
cifs: add tcon field to cifsFileInfo struct
cifs: make various routines use the cifsFileInfo->tcon pointer
cifs: fix handling of signing with writepages
cifs: add function to get a tcon from cifs_sb
cifs: temporarily rename cifs_sb->tcon to ptcon to catch stragglers
cifs: add cifs_sb_master_tcon and convert some callers to use it
cifs: have cifs_new_fileinfo take a tcon arg
cifs: add refcounted and timestamped container for holding tcons
cifs: have cifsFileInfo hold a reference to a tlink rather than tcon
pointer
cifs: have find_readable/writable_file filter by fsuid
cifs: fix cifs_show_options to show "username=" or "multiuser"
cifs: add routines to build sessions and tcons on the fly
cifs: on multiuser mount, set ownership to
current_fsuid/current_fsgid
cifs: add "multiuser" mount option
cifs: implement recurring workqueue job to prune old tcons

 fs/cifs/cifs_dfs_ref.c |   21 ++--
 fs/cifs/cifs_fs_sb.h   |   11 +-
 fs/cifs/cifsacl.c      |   46 +++++--
 fs/cifs/cifsfs.c       |   22 ++--
 fs/cifs/cifsglob.h     |   40 ++++++
 fs/cifs/cifsproto.h    |    8 +-
 fs/cifs/connect.c      |  339 +++++++++++++++++++++++++++++++++++++++++++++++-
 fs/cifs/dir.c          |   97 ++++++++++-----
 fs/cifs/file.c         |  161 +++++++++++++-----------
 fs/cifs/fscache.c      |   13 +-
 fs/cifs/inode.c        |  213 +++++++++++++++++++++++--------
 fs/cifs/ioctl.c        |   17 +--
 fs/cifs/link.c         |   88 ++++++++-----
 fs/cifs/misc.c         |    2 +-
 fs/cifs/readdir.c      |   45 ++++---
 fs/cifs/xattr.c        |   60 ++++++---
 16 files changed, 888 insertions(+), 295 deletions(-)
Signature · 1 line
1.7.2.3