Skip to content

Add lvm vg and pv properties for lvm2app.

Dave Wysochanski lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20Refactor metadata.[ch] into vg.[ch] for vg functions.include/.symlinks.in lib/Makefile.in lib/metadata/metadata-exported.h +4 more+567 -5220 replies
2/20Refactor metadata.[ch] into pv.[ch] for pv functions.include/.symlinks.in lib/Makefile.in lib/metadata/metadata-exported.h +3 more+300 -2570 replies
3/20Refactor metadata.[ch] into lv.[ch] for lv functions.include/.symlinks.in lib/Makefile.in lib/metadata/lv.c +3 more+76 -330 replies
4/20Add {pv|vg|lv}_attr_dup() functions and refactor 'disp' functions.lib/metadata/lv.c lib/metadata/lv.h lib/metadata/metadata.c +7 more+202 -1700 replies
5/20Simplify logic to create 'attr' strings.lib/metadata/lv.c lib/metadata/pv.c lib/metadata/vg.c+13 -580 replies
6/20Add id_format_and_copy() common function and call from _uuid_disp.lib/report/report.c lib/uuid/uuid.c lib/uuid/uuid.h+18 -60 replies
7/20Add pv_uuid_dup, vg_uuid_dup, and lv_uuid_dup, and call id_format_and_copy.lib/metadata/lv.c lib/metadata/lv.h lib/metadata/pv.c +6 more+23 -230 replies
8/20Add tags_format_and_copy() common function and call from _tags_disp.lib/metadata/metadata.c lib/metadata/metadata.h lib/report/report.c+28 -180 replies
9/20Add pv_tags_dup, vg_tags_dup, lv_tags_dup functions that call tags_format_and_copy.lib/metadata/lv.c lib/metadata/lv.h lib/metadata/pv.c +3 more+18 -00 replies
10/20Add supporting functions vg_name_dup, vg_fmt_dup, vg_system_id_dup.lib/metadata/vg.c lib/metadata/vg.h+20 -00 replies
11/20Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv.lib/report/properties.c+23 -21 reply
11/20Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv.+0 -00 replies
12/20Add 'get' functions for vg fields.lib/report/properties.c+22 -220 replies
13/20Add lvm_vg_get_property() generic vg property function.liblvm/lvm2app.h liblvm/lvm_vg.c+61 -00 replies
14/20Add tests for lvm_vg_get_property().test/api/test.c+33 -00 replies
15/20Add pv_mda_size, pv_mda_free, and pv_used functions, call from 'disp' functions.lib/metadata/pv.c lib/metadata/pv.h lib/report/report.c+56 -250 replies
16/20Add pv_name_dup() and pv_fmt_dup() helper functions.lib/metadata/pv.c lib/metadata/pv.h+14 -00 replies
17/20Add pv 'get' functions for all pv properties.lib/report/properties.c+16 -160 replies
18/20Add pv_get_property and create generic internal _get_property function.lib/report/properties.c lib/report/properties.h+152 -1230 replies
19/20Add lvm_pv_get_property() generic function to obtain value of any pv property.liblvm/lvm2app.h liblvm/lvm_pv.c+44 -00 replies
20/20Add pv_get_property to interactive test.test/api/test.c+51 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/20] Add lvm vg and pv properties for lvm2app.

This patchset is a repost and add onto the previous patchset posted to lvm-devel on 9/15/2010. It continues that patchset and adds pv properties and addresses comments made on the vg patchset.

Notable changes:
1. Refactor parts of metadata.[ch] into {pv|vg|lv}.ch.
2. Added 'const' to 'get' object functions
3. Improve type safety on vg_get_property() and pv_get_property()
4. Add "_dup" suffix to helper functions that allocate/dup strings.

All vg and pv properties may now be queried with this patchset. The refactoring of metadata.[ch] into specific files was only done for functions related to report field calculations. In the future, further functionality may be moved to these specific files, and common functions will remain inside metadata.[ch].