Constant udelay() for SMP and non-SMP systems
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 7 repliesIn review
- v44 patches 4 repliesSuperseded
- v34 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 12 replies | Superseded | |
| v1 | 3 patches | 15 replies | Superseded |
Changes in v5 from the cover letter
* Rebased against changes to udelay.S
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ARM: Translate delay.S into (mostly) Carch/ arch/ arch/ +1 more | +63 | 5 replies | |
| 2/3 | ARM: Allow machines to override __delay()arch/ arch/ | +18 | 1 reply | |
| 3/3 | ARM: Implement a timer based __delay() looparch/ arch/ | +19 | 1 reply |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Saravana Kannan | Mattias Wallin |
|---|---|---|
| 1/3 | R-b | T-b |
| 2/3 | R-b | T-b |
| 3/3 | Reported-and-reviewed-by | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv5 0/3] Constant udelay() for SMP and non-SMP systems
Note: I will submit this to the patch tracker in 48 hours. Tested by are appreciated.
These patches fix the udelay() issue pointed out on arm-lkml[1][2]. A quick recap: some SMP machines can scale their CPU frequencies independent of one another. loops_per_jiffy is calibrated globally and used in __const_udelay(). If one CPU is running faster than what the loops_per_jiffy is calculated (or scaled) for, udelay() will be incorrect and not wait long enough (or too long). A similar problem occurs if the cpu frequency is scaled during a udelay() call.
We could fix this issue a couple ways, wholesale replacement of __udelay() and __const_udelay() (see [2] for that approach), or replacement of __delay() (this series). Option 1 can fail if anybody uses udelay() before memory is mapped and also duplicates most of the code in asm/delay.h. It also needs to hardcode the timer tick frequency, which can sometimes be inaccurate. The benefit is that loops_per_jiffy stays the same and thus BogoMIPS is unchanged. Option 2 cannot fail since the __delay() loop is repointed after memory is mapped in, but it suffers from a low BogoMIPS when timers are clocked slowly. It also more accurately calculates the timer tick frequency through the use of calibrate_delay_direct().
-- Reference --
[1] http://article.gmane.org/gmane.linux.kernel/977567
[2] http://article.gmane.org/gmane.linux.ports.arm.kernel/78496
Changes since v4:
* Rebased against changes to udelay.S
Changes since v3:
* Inlined set_delay_fn()
Changes since v2:
* Additional patch using the timer based delay
Changes since v1:
* likely() in delay.c
* comment fixup for read_current_timer_delay_loop()
* cosmetic improvements to commit text
Stephen Boyd (3):
ARM: Translate delay.S into (mostly) C
ARM: Allow machines to override __delay()
ARM: Implement a timer based __delay() loop
arch/arm/include/asm/delay.h | 11 +++++- arch/arm/kernel/armksyms.c | 4 -- arch/arm/lib/delay.S | 69 --------------------------------- arch/arm/lib/delay.c | 87 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 97 insertions(+), 74 deletions(-) delete mode 100644 arch/arm/lib/delay.S create mode 100644 arch/arm/lib/delay.c
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.