xfstests: rework src/randholes.c
Get series with b4
b4 am 1287067771.2362.202.camel@doinkVersions newest first
- v1 Latest11 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | xfstests: randholes: Fix two bugssrc/ | +7 | 0 replies | |
| 2/11 | xfstests: randholes: only allocate write buffer when neededsrc/ | +26 | 0 replies | |
| 3/11 | xfstests: randholes: document options a bit moresrc/ | +21 | 0 replies | |
| 4/11 | xfstests: randholes: rearrange fns and drop their declarationssrc/ | +183 | 0 replies | |
| 5/11 | xfstests: randholes: hide some Irix/Linux differences more tidilysrc/ | +24 | 0 replies | |
| 6/11 | xfstests: randholes: encapsulate direct I/O setup codesrc/ | +19 | 0 replies | |
| 7/11 | xfstests: randholes: use posix_memalign()src/ | +47 | 0 replies | |
| 8/11 | xfstests: randholes: encapsulate realtime setup codesrc/ | +30 | 0 replies | |
| 9/11 | xfstests: randholes: clean up readblks()src/ | +27 | 0 replies | |
| 10/11 | xfstests: randholes: encapsulate argument parsingsrc/ | +75 | 0 replies | |
| 11/11 | xfstests: randholes: a few final cleanupssrc/ | +86 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/11] xfstests: rework src/randholes.c
Dave's recent "dynamic speculative EOF preallocation" changes caused test 008 to no longer produce the kinds of holes it was expecting to see, so it got me looking at the program it uses, "src/randholes.c".
Since 008 is the only test using this program, it probably doesn't deserve the attention I gave it yesterday, but I've done the work so I might as well submit the series for review and get my changes in.
The first patch in the series actually addresses two things that are bugs.
The remaining 10 are just cleanup and refactoring changes. Other than two bug fix changes and one change in output when running in very-verbose mode, the patched code should be pretty much functionally identical to before.
-Alex
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs