Skip to content

x86, NMI: give NMI handler a face-lift

Don Zickus lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 7 repliesIn review
  2. v26 patches 42 repliesSuperseded
  3. v15 patches 28 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9x86, NMI: Add NMI symbol constants and rename memory parity to PCI SERRarch/x86/include/asm/mach_traps.h arch/x86/kernel/traps.c+37 -260 replies
2/9x86, NMI: Add touch_nmi_watchdog to io_check_error delayarch/x86/kernel/traps.c+5 -30 replies
3/9x86, NMI: Rewrite NMI handlerarch/x86/kernel/cpu/perf_event.c arch/x86/kernel/traps.c arch/x86/oprofile/nmi_int.c +3 more+37 -340 replies
4/9x86, NMI: Remove DIE_NMI_IPI and add priorties to handlersarch/x86/include/asm/kdebug.h arch/x86/include/asm/nmi.h arch/x86/kernel/apic/hw_nmi.c +8 more+37 -255 replies
5/9x86, NMI: Allow NMI reason io port (0x61) to be processed on any CPUarch/x86/kernel/traps.c+21 -170 replies
6/9x86: only call smp_processor_id in non-preempt casesarch/x86/kernel/apic/hw_nmi.c+2 -11 reply
7/9x86: Avoid calling arch_trigger_all_cpu_backtrace() at the same timearch/x86/kernel/apic/hw_nmi.c+13 -00 replies
8/9panic: ratelimit panic messagesDocumentation/kernel-parameters.txt kernel/panic.c+36 -00 replies
9/9watchdog: touch_nmi_watchdog should only touch local cpu not every onekernel/watchdog.c+8 -70 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchBruce Ashfield
1/9
2/9
3/9
4/9
5/9
6/9
7/9R-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [V3 PATCH 0/9] x86, NMI: give NMI handler a face-lift

Restructuring the nmi handler to be more readable and simpler.

This is just laying the ground work for future improvements in this area.

I also left out one of Huang's patch until we figure out how we are going to proceed with a new notifier.

Tested 32-bit and 64-bit on AMD and Intel machines.

V3: rebased on top of removal of nmi watchdog
add a couple more watchdog patches from my queue

V2: add a patch to kill DIE_NMI_IPI and add in priorities

Cheers,
Don

Don Zickus (5):
x86, NMI: Remove DIE_NMI_IPI and add priorties to handlers
x86: only call smp_processor_id in non-preempt cases
panic: ratelimit panic messages
watchdog: touch_nmi_watchdog should only touch local cpu not every
one

Dongdong Deng (1):
x86: Avoid calling arch_trigger_all_cpu_backtrace() at the same time

Huang Ying (3):
x86, NMI: Add NMI symbol constants and rename memory parity to PCI
SERR
x86, NMI: Add touch_nmi_watchdog to io_check_error delay x86, NMI: Rewrite NMI handler
x86, NMI: Allow NMI reason io port (0x61) to be processed on any CPU

 Documentation/kernel-parameters.txt     |    6 ++
 arch/x86/include/asm/kdebug.h           |    1 -
 arch/x86/include/asm/mach_traps.h       |   12 +++-
 arch/x86/include/asm/nmi.h              |   20 ++++++
 arch/x86/kernel/apic/hw_nmi.c           |   19 ++++-
 arch/x86/kernel/apic/x2apic_uv_x.c      |    2 +-
 arch/x86/kernel/cpu/mcheck/mce-inject.c |    5 +-
 arch/x86/kernel/cpu/perf_event.c        |    3 +-
 arch/x86/kernel/kgdb.c                  |    6 +--
 arch/x86/kernel/reboot.c                |    5 +-
 arch/x86/kernel/traps.c                 |  114 ++++++++++++++++---------------
 arch/x86/oprofile/nmi_int.c             |    3 +-
 arch/x86/oprofile/nmi_timer_int.c       |    2 +-
 drivers/char/ipmi/ipmi_watchdog.c       |    2 +-
 drivers/watchdog/hpwdt.c                |    2 +-
 kernel/panic.c                          |   30 ++++++++
 kernel/watchdog.c                       |   17 +++--
 17 files changed, 166 insertions(+), 83 deletions(-)
Signature · 1 line
1.7.3.2