Skip to content

nVMX: Nested VMX, v6

Nadav Har'El kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest27 patches 28 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27nVMX: Add "nested" module option to vmx.carch/x86/kvm/vmx.c+8 -00 replies
2/27nVMX: Add VMX and SVM to list of supported cpuid featuresarch/x86/kvm/vmx.c+2 -00 replies
3/27nVMX: Implement VMXON and VMXOFFarch/x86/kvm/vmx.c+100 -23 replies
4/27nVMX: Allow setting the VMXE bit in CR4arch/x86/include/asm/kvm_host.h arch/x86/kvm/svm.c arch/x86/kvm/vmx.c +1 more+18 -71 reply
5/27nVMX: Introduce vmcs12: a VMCS structure for L1arch/x86/kvm/vmx.c+66 -03 replies
6/27nVMX: Implement reading and writing of VMX MSRsarch/x86/kvm/vmx.c arch/x86/kvm/x86.c+122 -11 reply
7/27nVMX: Decoding memory operands of VMX instructionsarch/x86/kvm/vmx.c arch/x86/kvm/x86.c arch/x86/kvm/x86.h+64 -10 replies
8/27nVMX: Hold a vmcs02 for each vmcs12arch/x86/kvm/vmx.c+96 -01 reply
9/27nVMX: Success/failure of VMX instructions.arch/x86/include/asm/vmx.h arch/x86/kvm/vmx.c+61 -00 replies
10/27nVMX: Implement VMCLEARarch/x86/kvm/vmx.c+61 -16 replies
11/27nVMX: Implement VMPTRLDarch/x86/kvm/vmx.c+63 -10 replies
12/27nVMX: Implement VMPTRSTarch/x86/kvm/vmx.c arch/x86/kvm/x86.c arch/x86/kvm/x86.h+31 -20 replies
13/27nVMX: Add VMCS fields to the vmcs12arch/x86/kvm/vmx.c+295 -01 reply
14/27nVMX: Implement VMREAD and VMWRITEarch/x86/kvm/vmx.c+169 -21 reply
15/27nVMX: Prepare vmcs02 from vmcs01 and vmcs12arch/x86/kvm/vmx.c+408 -06 replies
16/27nVMX: Move register-syncing to a functionarch/x86/kvm/vmx.c+10 -50 replies
17/27nVMX: Implement VMLAUNCH and VMRESUMEarch/x86/kvm/vmx.c+218 -31 reply
18/27nVMX: No need for handle_vmx_insn function any morearch/x86/kvm/vmx.c+0 -60 replies
19/27nVMX: Exiting from L2 to L1arch/x86/kvm/vmx.c+235 -01 reply
20/27nVMX: Deciding if L0 or L1 should handle an L2 exitarch/x86/kvm/vmx.c+205 -02 replies
21/27nVMX: Correct handling of interrupt injectionarch/x86/kvm/vmx.c+33 -00 replies
22/27nVMX: Correct handling of exception injectionarch/x86/kvm/vmx.c+26 -00 replies
23/27nVMX: Correct handling of idt vectoring infoarch/x86/kvm/vmx.c+32 -00 replies
24/27nVMX: Handling of CR0.TS and #NM for Lazy FPU loadingarch/x86/kvm/vmx.c+85 -50 replies
25/27nVMX: Additional TSC-offset handlingarch/x86/kvm/vmx.c+11 -01 reply
26/27nVMX: Miscellenous small correctionsarch/x86/kvm/vmx.c+1 -10 replies
27/27nVMX: DocumentationDocumentation/kvm/nested-vmx.txt+237 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/27] nVMX: Nested VMX, v6

Hi,

About three months have passed since my previous (v5) nested VMX patch set, and it can no longer be applied cleanly to the current KVM trunk.

This version of the patches can be applied to the current trunk, and addresses dozens of concerns that have been raised by Avi Kivity, Marcelo Tosatti, Gleb Natapov, and Eddie Dong while reviewing v5.
There are still several outstanding issues (e.g., that IDT handling code that we've been discussing) that are not addressed in this version, but rest assured that I have not forgotten them - I simply want a newer version, and one that works with a current KVM, to be available to potential reviewers or testers.

About nested VMX:
-----------------

The following 27 patches implement nested VMX support. This feature enables a guest to use the VMX APIs in order to run its own nested guests. In other words, it allows running hypervisors (that use VMX) under KVM. Multiple guest hypervisors can be run concurrently, and each of those can in turn host multiple guests.

The theory behind this work, our implementation, and its performance characteristics were presented this month in OSDI (the USENIX Symposium on Operating Systems Design and Implementation). Our paper was titled "The Turtles Project: Design and Implementation of Nested Virtualization", and was awarded "Jay Lepreau Best Paper". The paper is available online, at:

http://www.usenix.org/events/osdi10/tech/full_papers/Ben-Yehuda.pdf

This patch set does not include all the features described in the paper. In particular, this patch set is missing nested EPT (shadow page tables are used) and missing some features required to run VMWare Server as a guest. These missing features will be sent as follow-on patchs.

Running nested VMX:
------------------

The current patches have a number of requirements, which will be relaxed in follow-on patches:

1. This version was only tested with KVM (64-bit) as a guest hypervisor, and Linux as a nested guest.

2. SMP is supported in the code, but is unfortunately buggy in this version and often leads to hangs. Use the "nosmp" option in the L0 (topmost) kernel to avoid this bug (and to reduce your performance ;-))..

3. No modifications are required to user space (qemu). However, qemu does not currently list "VMX" as a CPU feature in its emulated CPUs (even when they are named after CPUs that do normally have VMX). Therefore, the "-cpu host" option should be given to qemu, to tell it to support CPU features which exist in the host - and in particular VMX.
This requirement can be made unnecessary by a trivial patch to qemu (which I will submit in the future).

4. The nested VMX feature is currently disabled by default. It must be explicitly enabled with the "nested=1" option to the kvm-intel module.

5. Nested EPT and VPID are not properly supported in this version. You must give the "ept=0 vpid=0" module options to kvm-intel to turn both features off.

Patch statistics:
-----------------

 Documentation/kvm/nested-vmx.txt |  237 ++
 arch/x86/include/asm/kvm_host.h  |    2 
 arch/x86/include/asm/vmx.h       |   31 
 arch/x86/kvm/svm.c               |    6 
 arch/x86/kvm/vmx.c               | 2396 ++++++++++++++++++++++++++++-
 arch/x86/kvm/x86.c               |   16 
 arch/x86/kvm/x86.h               |    6 
 7 files changed, 2657 insertions(+), 37 deletions(-)

--
Nadav Har'El
IBM Haifa Research Lab