Skip to content

Add generic property fns for lvm2app, return struct, v2.

Dave Wysochanski lvm-devel 1 version New

Get series with b4
b4 am 1288014832.5029.0.camel@f12-work

Versions newest first

  1. v1 Latest0 of 5 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/05] Add generic property fns for lvm2app, return struct, v2.
Quoted 22 lines · Petr Rockai

Hi,

Quoted 8 lines · Dave Wysochanski

This is the modified patchset based on Petr's suggestion of changing the return value from 'int' to struct lvm_property_value:
http://www.redhat.com/archives/lvm-devel/2010-October/msg00068.html

Returning the struct seems like the approach things are moving, but a few details probably still worth considering, especially the exact layout of the exported struct lvm_property_value (ABI implications). Final submission might be best left to Petr.

I think I almost prefer to have this in tree now and tweak the layouts etc. afterwards. I think that all that needs to be done is to pad the bit-field, the union is already 64b wide so we shouldn't need anything else. I'll have a closer look next week.

Quoted 6 lines

Patchset adds the lvm2app 'get' functions for vg, pv, and lv, and interactive tests to exercise the interface.

The only two lv properties not included now are still the float/percent based properties, snap_percent and copy_percent. These should be refactored carefully and I did not want to delay these patches further.

Quoted 7 lines

I will sort these out myself as well.

I went through the individual patches and I don't have any specific comments. So I think all five can go in now, and I'll look at finishing the two above items and will look into test coverage that we already have and maybe extend it. Therefore,

Very good. As you wish Petr - will check them in!

Quoted 2 lines