Skip to content

x86: Eliminate bp argument from the stack tracing routines

Søren Sandmann Pedersen lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 3 repliesIn review

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] x86: Eliminate bp argument from the stack tracing routines

Hi,

This is a resurrection of an old patch that I sent about a year ago:

     http://lkml.org/lkml/2009/10/22/192

At the time, I thought the patch broke perf callchains on 64 bit, but it turns out that those are broken even without this patch.

I don't know why that is, but I now think the patch is correct and to blame.

(FWIW, this

arch/x86/kernel/cpu/perf_event.c +1 -1
index 461a85d..d977d26 100644
@@ -1653,7 +1653,7 @@ static const struct stacktrace_ops backtrace_ops = {
 	.warning_symbol		= backtrace_warning_symbol,
 	.stack			= backtrace_stack,
 	.address		= backtrace_address,
-	.walk_stack		= print_context_stack_bp,
+	.walk_stack		= print_context_stack,
 };
 

makes it produce correct kernel callchains. And yes, I did compile the kernel with CONFIG_FRAME_POINTER).

Soren