Skip to content

GNU C compiler warning clean-up

David Sommerseth openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Use stricter snprintf() formatting in socks_username_password_auth()socks.c+2 -25 replies
2/6Fix compiler warnings about not used dummy() functionscryptoapi.c ieproxy.c perf.c +1 more+8 -10 replies
3/6Fixed potential misinterpretation of boolean logicssl.c+1 -10 replies
4/6Only add some functions when really neededoptions.c reliable.c+4 -00 replies
5/6Removed functions not being used anywhereps.c sig.c+0 -210 replies
6/6Merged add_bypass_address() and add_host_route_if_nonlocal()route.c+12 -220 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Stuge
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/6] GNU C compiler warning clean-up

The GNU C compiler gives a lot of different warnings when compiling with -Wall set. This patch-set tries to clean up all these issues, hopefully without breaking anything for other compilers - especially on the Windows platform.

David Sommerseth (6):
Use stricter snprintf() formatting in socks_username_password_auth() Fix compiler warnings about not used dummy() functions Fixed potential misinterpretation of boolean logic
Only add some functions when really needed
Removed functions not being used anywhere
Merged add_bypass_address() and add_host_route_if_nonlocal()

 cryptoapi.c |    2 ++
 ieproxy.c   |    3 ++-
 options.c   |    2 ++
 perf.c      |    2 ++
 pkcs11.c    |    2 ++
 ps.c        |   12 ------------
 reliable.c  |    2 ++
 route.c     |   34 ++++++++++++----------------------
 sig.c       |    9 ---------
 socks.c     |    4 ++--
 ssl.c       |    2 +-
 11 files changed, 27 insertions(+), 47 deletions(-)
Signature · 1 line
1.7.2.3