Skip to content

AHCI emulation support v4

Alexander Graf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 15 repliesIn review

v1 -> v2 from the cover letter

- rename IDEExtender to IDEBusOps and make a pointer (kraxel)
- make dma hooks explicit by putting them into ops struct (stefanha)
- use qdev buses (kraxel)
- minor cleanups
- dprintf overhaul
- add reset function

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ide: split ide command interpretation offhw/ide/core.c hw/ide/internal.h+16 -60 replies
2/12ide: fix whitespace gap in ide_exec_cmdhw/ide/core.c+367 -3670 replies
3/12ide: add support for ide bus opshw/ide/core.c hw/ide/internal.h+54 -80 replies
4/12ide: add DMA hooks to bus opshw/ide/core.c hw/ide/internal.h+10 -30 replies
5/12ide: add ncq identify data for ahci sata driveshw/ide/core.c hw/ide/internal.h+9 -00 replies
6/12pci: add storage class for satahw/pci_ids.h+1 -00 replies
7/12pci: add ich7 pci idhw/pci.h+1 -00 replies
8/12ahci: add ahci emulationMakefile.objs default-configs/i386-softmmu.mak default-configs/x86_64-softmmu.mak +1 more+1400 -05 replies
9/12ahci: add -drive supportblockdev.c blockdev.h qemu-common.h+7 -20 replies
10/12config: Add header file for device config optionsMakefile.target hw/pc_piix.c+5 -15 replies
11/12ahci: spawn controller on demandhw/pc.h hw/pc_piix.c+4 -00 replies
12/12ide: move pata specific parts to pata.cMakefile.objs hw/ide/core.c hw/ide/internal.h +1 more+184 -1430 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/12] AHCI emulation support v4

This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports NCQ, so multiple read or write requests can be outstanding at the same time.

The code is however not fully optimized yet. I'm fairly sure that there are low hanging performance fruits to be found still :). In my simple benchmarks I achieved about 2/3rd of virtio performance.

Also, this AHCI emulation layer does not support legacy mode. So if you're using a disk with this emulation, you do not get it exposed using the legacy IDE interfaces.

Another nitpick is CD-ROM support in Windows. Somehow it doesn't detect a CD-ROM drive attached to AHCI. At least it doesn't list it.

To attach an AHCI disk to your VM, please use

-drive file=...,if=sata

This should do the trick for x86. On other platforms, you need to add the ahci host controller using -device and add CONFIG_AHCI to its default config. Big endian hosts are still broken due to qemu shortcomings in mmio handing. Expect patches to follow.

This patch set is based on work done during the Google Summer of Code. I was mentoring a student, Roland Elek, who wrote most of the AHCI emulation code based on a patch from Chong Qiao. A bunch of other people were also involved, so everybody who I didn't mention - thanks a lot!

git://repo.or.cz/qemu/ahci.git ahci

v1 -> v2:

- rename IDEExtender to IDEBusOps and make a pointer (kraxel)
- make dma hooks explicit by putting them into ops struct (stefanha)
- use qdev buses (kraxel)
- minor cleanups
- dprintf overhaul
- add reset function

v2 -> v3:

- add msi support (kraxel)
- use MIN macro (kraxel)
- add msi support (kraxel)
- fix ncq with multiple ports
- zap qdev properties (kraxel)
- redesign legacy IF_SATA hooks (kraxel)
- don't build ahci as part of target
- move to ide/ (kwolf)

v3 -> v4:

- prepare for endianness safety
- add lspci dump (herbszt)
- use ich7 instead of ich7m (herbszt)
- fix lst+fis mapping (kraxel)
- coding style (blue swirl)
- explicit mmio setters/getters (blue swirl)
- split pata code out to pata.c (kwolf)
- only include config-devices.h in machine description (blue swirl)

Alex

Alexander Graf (10):
ide: split ide command interpretation off
ide: fix whitespace gap in ide_exec_cmd
ide: add DMA hooks to bus ops
pci: add storage class for sata
pci: add ich7 pci id
ahci: add ahci emulation
ahci: add -drive support
config: Add header file for device config options
ahci: spawn controller on demand
ide: move pata specific parts to pata.c

Roland Elek (2):
ide: add support for ide bus ops
ide: add ncq identify data for ahci sata drives

 Makefile.objs                      |    3 +-
 Makefile.target                    |    5 +-
 blockdev.c                         |    6 +-
 blockdev.h                         |    1 +
 default-configs/i386-softmmu.mak   |    1 +
 default-configs/x86_64-softmmu.mak |    1 +
 hw/ide/ahci.c                      | 1397 ++++++++++++++++++++++++++++++++++++
 hw/ide/core.c                      |  874 ++++++++++-------------
 hw/ide/internal.h                  |   37 +-
 hw/ide/pata.c                      |  178 +++++
 hw/pc.h                            |    1 +
 hw/pc_piix.c                       |    4 +
 hw/pci.h                           |    1 +
 hw/pci_ids.h                       |    1 +
 qemu-common.h                      |    2 +-
 15 files changed, 2020 insertions(+), 492 deletions(-)
 create mode 100644 hw/ide/ahci.c
 create mode 100644 hw/ide/pata.c