Skip to content

Megasas HBA emulation and SCSI update v.3

Hannes Reinecke qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 22 repliesIn review

v2 -> v3 from the cover letter

- Include review by Stefan Hajnoczi
- Return SCSI error status on invalid data direction
- Initialize sense code in scsi-generic.c

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15scsi: Increase the number of possible devicesblockdev.h hw/scsi-bus.c hw/scsi.h+4 -30 replies
2/15scsi: Return SAM status codeshw/scsi-defs.h hw/scsi-generic.c+16 -141 reply
3/15scsi: INQUIRY VPD fixeshw/scsi-disk.c+14 -40 replies
4/15scsi: Move sense handling into the driverhw/scsi-bus.c hw/scsi-disk.c hw/scsi.h+25 -260 replies
5/15scsi-disk: Remove duplicate cdb parsinghw/scsi-disk.c+21 -530 replies
6/15scsi: Update sense code handlinghw/scsi-bus.c hw/scsi-disk.c hw/scsi-generic.c +1 more+239 -762 replies
7/15lsi53c895a: Rename 'sense' to 'status'hw/lsi53c895a.c+9 -90 replies
8/15scsi-disk: Allocate iovec dynamicallyhw/scsi-disk.c+60 -420 replies
9/15scsi: Use 'SCSIRequest' directlyhw/esp.c hw/lsi53c895a.c hw/scsi-bus.c +4 more+136 -2350 replies
10/15scsi-disk: add data direction checkinghw/scsi-disk.c+22 -80 replies
11/15Remove 'bus' argument from SCSI command completion callbackshw/esp.c hw/lsi53c895a.c hw/scsi-bus.c +4 more+15 -200 replies
12/15scsi: Implement 'get_sense' callbackhw/scsi-disk.c hw/scsi-generic.c hw/scsi.h+28 -00 replies
13/15scsi: Implement alloc_req_iov callbackhw/scsi-disk.c hw/scsi-generic.c hw/scsi.h+56 -155 replies
14/15megasas: LSI Megaraid SAS emulationMakefile.objs hw/megasas.c hw/mfi.h +2 more+3029 -15 replies
15/15Make SCSI HBA configurableMakefile.objs default-configs/i386-softmmu.mak default-configs/mips-softmmu.mak +9 more+20 -70 replies

Reviews trailers per patch

9 of 15 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigStefan HajnocziPaolo BonziniJes Sorensen
1/15A-b
2/15
3/15A-b
4/15A-b
5/15A-b
6/15A-b
7/15R-b
8/15
9/15A-b
10/15
11/15R-b
12/15
13/15
14/15
15/15A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/15] Megasas HBA emulation and SCSI update v.3

The is the third version of the megasas patchset; changes are:
v2 -> v3:
- Include review by Stefan Hajnoczi
- Return SCSI error status on invalid data direction
- Initialize sense code in scsi-generic.c

v1 -> v2:
- Include suggestions (and acked-by) from Christoph Hellwig
- Updated patch description as requested by Gerd Hoffman
- Use generic iov_size() implementation
- Drop old patches
- Make SCSI HBA configurable

This patchset can be found at

git://repo.or.cz/qemu/megasas.git
branch megasas.v3

The original description was:
Due to popular demand here is now the LSI Megaraid HBA emulation. And an update to the SCSI stack to bring it more in line with modern standards.

For the SCSI update there are three key points:
- Improved sense code handling: the SCSI standard specifies several sense codes to be returned on common errors; we should be following that.
- Reworked SCSI layer: Instead of indirectly addressing a SCSI request by an abstract 'tag' we're now using the request directly, thus saving us a lookup on every invocation.
- Add iovec passing: I've added an interface to pass an iovec to a SCSI request, so that we don't need to use bounce buffers for data transfer. The old interface is left in place.

And, of course, the megasas driver itself.

A quick 'dd' comparison against virtio on a tmpfs backed sparse file shows:

# dd if=/dev/sdb of=/dev/null bs=16M count=1000 iflag=direct
1000+0 records in
1000+0 records out
16777216000 bytes (17 GB) copied, 9.40123 s, 1.8 GB/s
# dd if=/dev/vda of=/dev/null bs=16M count=1000 iflag=direct
1000+0 records in
1000+0 records out
16777216000 bytes (17 GB) copied, 7.44681 s, 2.3 GB/s

So we're having about 80% virtio speed.
Unoptimized :-)

Hannes Reinecke (15):
scsi: Increase the number of possible devices
scsi: Return SAM status codes
scsi: INQUIRY VPD fixes
scsi: Move sense handling into the driver
scsi-disk: Remove duplicate cdb parsing
scsi: Update sense code handling
lsi53c895a: Rename 'sense' to 'status'
scsi-disk: Allocate iovec dynamically
scsi: Use 'SCSIRequest' directly
scsi-disk: add data direction checking
Remove 'bus' argument from SCSI command completion callbacks
scsi: Implement 'get_sense' callback
scsi: Implement alloc_req_iov callback
megasas: LSI Megaraid SAS emulation
Make SCSI HBA configurable

 Makefile.objs                        |    5 +-
 blockdev.h                           |    2 +-
 default-configs/i386-softmmu.mak     |    2 +
 default-configs/mips-softmmu.mak     |    2 +-
 default-configs/mips64-softmmu.mak   |    2 +-
 default-configs/mips64el-softmmu.mak |    2 +-
 default-configs/mipsel-softmmu.mak   |    2 +-
 default-configs/ppc-softmmu.mak      |    2 +
 default-configs/ppc64-softmmu.mak    |    2 +
 default-configs/ppcemb-softmmu.mak   |    2 +
 default-configs/sparc-softmmu.mak    |    2 +-
 default-configs/sparc64-softmmu.mak  |    2 +
 default-configs/x86_64-softmmu.mak   |    2 +
 hw/esp.c                             |   23 +-
 hw/lsi53c895a.c                      |   47 +-
 hw/megasas.c                         | 1828 ++++++++++++++++++++++++++++++++++
 hw/mfi.h                             | 1197 ++++++++++++++++++++++
 hw/pci_ids.h                         |    2 +
 hw/scsi-bus.c                        |  120 ++-
 hw/scsi-defs.h                       |   20 +-
 hw/scsi-disk.c                       |  459 +++++-----
 hw/scsi-generic.c                    |  239 +++--
 hw/scsi.h                            |   65 +-
 hw/usb-msd.c                         |   26 +-
 24 files changed, 3618 insertions(+), 437 deletions(-)
 create mode 100644 hw/megasas.c
 create mode 100644 hw/mfi.h