Skip to content

RFC v2: AF_ALG auditing

Miloslav Trmač linux-audit linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Changes since the previous version from the cover letter

* Use audit_aux_data instead of a separate linked list
* Don't overwrite initial values of "err" by 0 in algif_skcipher.c Mirek

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Add general crypto auditing infrastructureinclude/linux/audit.h kernel/auditfilter.c kernel/auditsc.c+121 -00 replies
2/5Add unique IDs to AF_ALG socketscrypto/af_alg.c crypto/algif_hash.c crypto/algif_skcipher.c +1 more+71 -90 replies
3/5Add "alg_name" operation to af_alg_type.crypto/algif_hash.c crypto/algif_skcipher.c include/crypto/if_alg.h+13 -00 replies
4/5Audit type-independent eventscrypto/af_alg.c+30 -00 replies
5/5Audit type-specific crypto operationscrypto/af_alg.c crypto/algif_hash.c crypto/algif_skcipher.c +1 more+61 -60 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHerbert Xu
SeriesA-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] RFC v2: AF_ALG auditing

Hello,
these patches add support for auditing uses of the AF_ALG protocol family developed by Herbert Xu to provide user-space access to kernel crypto accelerators.

One new record is defined: AUDIT_CRYPTO_USERSPACE_OP. An audited event is always caused by a syscall, and all other syscall-related data (process identity, syscall result) is audited in the usual records.

To disable auditing crypto by default and to allow the users to selectively enable them using filters, a new filter field AUDIT_CRYPTO_OP is defined; auditing of all crypto operations can thus be enabled using (auditctl -a exit,always -F crypto_op!=0).

Changes since the previous version:
* Use audit_aux_data instead of a separate linked list
* Don't overwrite initial values of "err" by 0 in algif_skcipher.c Mirek

Miloslav Trmač (5):
Add general crypto auditing infrastructure
Add unique IDs to AF_ALG sockets
Add "alg_name" operation to af_alg_type.
Audit type-independent events
Audit type-specific crypto operations

 crypto/af_alg.c         |  110 ++++++++++++++++++++++++++++++++++++++++++++++-
 crypto/algif_hash.c     |   35 +++++++++++++--
 crypto/algif_skcipher.c |   28 +++++++++++-
 include/crypto/if_alg.h |   17 +++++--
 include/linux/audit.h   |   22 +++++++++
 kernel/auditfilter.c    |    2 +
 kernel/auditsc.c        |   97 +++++++++++++++++++++++++++++++++++++++++
 7 files changed, 296 insertions(+), 15 deletions(-)
Signature · 1 line
1.7.3.2