Skip to content

Patch Description

Yang Gu ofono 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3network: Use bit as size instead of bytesrc/network.c+2 -21 reply
2/3stk: Handle provide local info proactive commandsrc/smsutil.c src/stk.c src/stkagent.c +2 more+284 -44 replies
3/3test-stk: Add provide local infotest/test-stk-menu+36 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Patch Description

This series of patch is to add provide local info support by requesting the terminal to send time and language info. Please comment on the following aspects as I'm not sure after reading the spec:
1. Timezone may be a number in the range -47 through +48. In struct sms_scts, timezone is defined as gint8, thus 0xFF should shand for -1, which is a valid input. Thus I think build_dataobj_datetime_timezone() in src/stkutil.c is not correct. But I'm still not sure what value should be passed to oFono when timezone is absent.
2. DBUS_TYPE_BYTE represents an 8-bit unsigned integer, and D-Bus doesn't have a type related to 8-bit signed integer. So what's the best way to represent a timezone?
3. Only one byte is used to represent the year. Is the following logic correct to get the year with one byte?
if (year_dbus >= 2000)

	year = year_dbus - 2000;
else
	year = year_dbus - 1900; 

Yang Gu (3):
network: Use bit as size instead of byte
stk: Handle provide local info proactive command
test-stk: Add provide local info

 src/network.c      |    4 +-
 src/smsutil.c      |    6 +-
 src/stk.c          |  113 ++++++++++++++++++++++++++++++++++++++
 src/stkagent.c     |  153 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/stkagent.h     |   14 +++++
 src/stkutil.c      |    2 +-
 test/test-stk-menu |   36 ++++++++++++
 7 files changed, 322 insertions(+), 6 deletions(-)
Signature · 1 line
1.7.2.3