Skip to content

megaraid_sas: Convert to host_lock less w/ interrupts disabled internally

Nicholas A. Bellinger linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3megaraid_sas: Add smp_mb__after_atomic_*() for instance->fw_outstandingdrivers/scsi/megaraid/megaraid_sas.c+4 -00 replies
2/3megaraid_sas: Convert instance->issuepend_done to atomic_tdrivers/scsi/megaraid/megaraid_sas.c drivers/scsi/megaraid/megaraid_sas.h+7 -80 replies
3/3megaraid_sas: Convert SHT->queuecommand() to run host_lock-lessdrivers/scsi/megaraid/megaraid_sas.c+46 -212 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] megaraid_sas: Convert to host_lock less w/ interrupts disabled internally

From: Nicholas Bellinger <[email protected]>

Greetings Hannes, Bo and Co,

This series converts megaraid_sas to run in modern host_lock-less mode for >= .37-rc3+ with interrupts disabled internally around megasas_instance->hba_lock. This series is currently living in lio-core-2.6.git/lock_less-LLDs-for-38-v2, and is intended for .38 mainline code.

The first patch adds a handful of missing barriers around instance->fw_outstanding usage w/ atomic_add() and atomic_dec().

The second converts instance->issuepend_done to an atomic_t, along with the necessary assignments in order to run w/ Scsi_Host->host_lock, and without instance->hba_lock.

The third patch does the actual conversion, and adds a __megasas_get_cmd() usased by megasas_queue_command() w/ instance->hba_lock, along with being held for megasas_build_ldio() and megasas_build_dcdb() in order to locate the proper frame for struct megasas_cmd. This is really the one major change in order to get host_lock-less to function with interrupts disabled around hba_lock.

So far this has been tested with Hannes's QEMU 8708EM2 HBA emulation with TCM_Loop backends using SG_IO from KVM host in a paired Host/Guest .37-rc3 environment. This has not been tested on real silicon yet, but I believe this series should be working there as well.

Comments are welcome, thanks!

Nicholas Bellinger (3):
megaraid_sas: Add smp_mb__after_atomic_*() for

    instance->fw_outstanding

megaraid_sas: Convert instance->issuepend_done to atomic_t
megaraid_sas: Convert SHT->queuecommand() to run host_lock-less

 drivers/scsi/megaraid/megaraid_sas.c |   84 ++++++++++++++++++++++-----------
 drivers/scsi/megaraid/megaraid_sas.h |    2 +-
 2 files changed, 57 insertions(+), 29 deletions(-)
Signature · 1 line
1.7.2.3