Skip to content

xfs: buffer cache shrinker overhaul V2

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: convert xfsbud shrinker to a per-buftarg shrinker.fs/xfs/linux-2.6/xfs_buf.c fs/xfs/linux-2.6/xfs_buf.h+27 -660 replies
2/3xfs: add a lru to the XFS buffer cachefs/xfs/linux-2.6/xfs_buf.c fs/xfs/linux-2.6/xfs_buf.h+150 -221 reply
3/3xfs: connect up buffer reclaim priority hooksfs/xfs/linux-2.6/xfs_buf.h fs/xfs/xfs_btree.c fs/xfs/xfs_inode.c +1 more+14 -91 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigAlex Elder
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] xfs: buffer cache shrinker overhaul V2

This series adds a per-filesystem LRU to the buffer cache. When combined with a shrinker per filesystem, this enables us to prioritise reclaim of buffers under memory pressure. This solves the current problem of page cache reclaim having no concept of what the pages actually contain in deciding which pages to reclaim.

The LRU is lazily updated, meaning that we only access the LRU lists and locks when the last reference to a buffer goes away. As a result, there is no impact to the hot buffer lookup path and we are not constantly moving buffers around in the LRU.

This series effectively means that the buffer cache can now be made independent of the page cache as we now have our own optimised buffer cache reclaim mechanisms.

Version 2:

- removed buffer lru addition during xfs_buf_find() as it is done lazily on the last reference going away.
- removed buffer type additions and used the existing macro to just set the reference value.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs