Skip to content

xfs: AIL lock contention reduction V2

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 8 patches 13 repliesIn review

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8xfs: Pull EFI/EFD handling out from under the AIL lockfs/xfs/xfs_extfree_item.c fs/xfs/xfs_extfree_item.h fs/xfs/xfs_log_recover.c +1 more+59 -484 replies
2/8xfs: clean up xfs_ail_delete()fs/xfs/xfs_trans_ail.c+7 -201 reply
3/8xfs: bulk AIL insertion during transaction commitfs/xfs/xfs_log_cil.c fs/xfs/xfs_trans.c fs/xfs/xfs_trans_ail.c +1 more+182 -102 replies
4/8xfs: reduce the number of AIL push wakeupsfs/xfs/linux-2.6/xfs_super.c+16 -41 reply
5/8xfs: consume iodone callback items on buffers as they are processedfs/xfs/xfs_buf_item.c+21 -111 reply
6/8xfs: remove all the inodes on a buffer from the AIL in bulkfs/xfs/xfs_inode_item.c fs/xfs/xfs_trans_ail.c fs/xfs/xfs_trans_priv.h+142 -163 replies
8/8xfs: use AIL bulk delete function to implement single deletefs/xfs/xfs_trans_ail.c fs/xfs/xfs_trans_priv.h+18 -721 reply

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/8
2/8R-b
3/8
4/8R-b
5/8R-b
6/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] xfs: AIL lock contention reduction V2

This series reduces AIL locking overhead by introducing bulk operations for insert and delete. With delayed logging, we can be doing insert operations on thousands of items at a time, so using a bulk operation to reduce AIL lock traffic is a major win in terms of reducing contention on the lock.

Similarly, when we have inode buffer IO completion running on multiple CPUs at once, the AIl lock contention from each individual AIL removal is significant. By batching all the inodes on the buffer to be removed from the AIL in a single bulk operation, contention on the AIL is reduced by an order of magnitude.

Finally, there is a modification to the xfsaild wakeup code to prevent too many wakeups when the xfsaild is pausing waiting for some work to complete. This prevents an excessive number of AIL scanning traversals by the xfsaild when tail pushing is backing off and waiting for some IO to complete.

In combination, these modification reduce AIL lock contention sufficiently to drop the AIL lock out of the "top 10" contended locks on 8-way fs_mark and dbench workloads.

Version 2:

- split out stale inode AIL insertion bug fix
- split bulk AIL insertion into multiple patches
- EFI/EFD handling changes
- stale inode AIL insertion bug fix
- simplify code calling xfs_ail_delete
- bulk ail insertion modifications
- use atomic_inc_return for extent recording in xfs_trans_log_efi_extent()
- modified AIL sleep code to explicitly set task state as suggested by Christoph.
- split AIL bulk deletion into two patches
- buffer iodone callback modifications
- bulk AIL deletion and inode iodone callback mods.
- removed lip parameter from xfs_buf_do_callbacks() as the loop fetches it from the buffer anyway.
- fixed unused variable warning in xfs_buf_do_callbacks().
- added two new patches to reduce code duplication
- use AIL bulk insertion function to implement single updates
- use AIL bulk delete function to implement single deletes

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs