Skip to content

e2fsprogs cleanups

Namhyung Kim linux-ext4 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 23 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/15libext2fs: fix potential build failure with OMIT_COM_ERRlib/ext2fs/gen_bitmap.c+6 -61 reply
2/15libext2fs: fix dubious code in ext2fs_numeric_progress_init()lib/ext2fs/progress.c+1 -11 reply
3/15mke2fs: simplify inode table block countingmisc/mke2fs.c+2 -53 replies
4/15libext2fs: remove unnecessary casts to ext2fs_generic_bitmaplib/ext2fs/gen_bitmap64.c+26 -431 reply
5/15libext2fs: fix dubious code in ext2fs_unmark_generic_bitmap()lib/ext2fs/gen_bitmap.c+1 -11 reply
6/15libext2fs: invalid EXT4_FEATURE_RO_COMPAT_HUGE_FILE checkslib/ext2fs/blknum.c+2 -21 reply
7/15libext2fs: fix error path in ext2fs_update_bb_inode()lib/ext2fs/bb_inode.c+4 -21 reply
8/15libext2fs: fix memory leak on error pathlib/ext2fs/inode_io.c+3 -12 replies
9/15mke2fs: check return value of e2p_os2string()misc/mke2fs.c+4 -01 reply
10/15mke2fs.8.in: add missing "big" and "huge" usage-type descriptionmisc/mke2fs.8.in+10 -11 reply
11/15mke2fs: fix determination of size_typemisc/mke2fs.c+2 -24 replies
12/15mke2fs: add some error checks into PRS()misc/mke2fs.c+22 -45 replies
13/15mke2fs: fix potential memory leak in mke2fs_setup_tdb()misc/mke2fs.c+7 -44 replies
14/15libext2fs: fix possible memory leak in write_journal_inode()lib/ext2fs/mkjournal.c+1 -01 reply
15/15mke2fs.8.in: add ENVIRONMENT sectionmisc/mke2fs.8.in+23 -01 reply

Reviews trailers per patch

2 of 15 patches have a Reviewed-by or Acked-by.

PatchLukas Czerner
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15R-b
13/15R-b
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] e2fsprogs cleanups

Hi,

This is a series of small patches that I found during reading the mke2fs code. Most of them are fix of (potential) memory leaks and addition of more error checks. Plus a couple of dubious code fix and trivial cleanups. The man page of mke2fs also be updated.

Any comments/suggestions are welcomed.
Thanks.

---

Namhyung Kim (15):
libext2fs: fix potential build failure with OMIT_COM_ERR
libext2fs: fix dubious code in ext2fs_numeric_progress_init()
mke2fs: simplify inode table block counting
libext2fs: remove unnecessary casts to ext2fs_generic_bitmap
libext2fs: fix dubious code in ext2fs_unmark_generic_bitmap()
libext2fs: invalid EXT4_FEATURE_RO_COMPAT_HUGE_FILE checks
libext2fs: fix error path in ext2fs_update_bb_inode()
libext2fs: fix memory leak on error path
mke2fs: check return value of e2p_os2string() mke2fs.8.in: add missing "big" and "huge" usage-type description
mke2fs: fix determination of size_type
mke2fs: add some error checks into PRS()
mke2fs: fix potential memory leak in mke2fs_setup_tdb()
libext2fs: fix possible memory leak in write_journal_inode() mke2fs.8.in: add ENVIRONMENT section

 lib/ext2fs/bb_inode.c     |    6 ++-
 lib/ext2fs/blknum.c       |    4 +-
 lib/ext2fs/gen_bitmap.c   |   14 ++++----
 lib/ext2fs/gen_bitmap64.c |   69 +++++++++++++++++----------------------------
 lib/ext2fs/inode_io.c     |    4 ++-
 lib/ext2fs/mkjournal.c    |    1 +
 lib/ext2fs/progress.c     |    2 +-
 misc/mke2fs.8.in          |   34 +++++++++++++++++++++-
 misc/mke2fs.c             |   52 ++++++++++++++++++++++++----------
 9 files changed, 114 insertions(+), 72 deletions(-)