Skip to content

ARM: hw_breakpoint: fixes and improvements (v2)

Will Deacon linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ARM: hw_breakpoint: ensure OS lock is clear before writing to debug registersarch/arm/kernel/hw_breakpoint.c+22 -50 replies
2/8ARM: hw_breakpoint: reset control registers in hotplug patharch/arm/kernel/hw_breakpoint.c+15 -10 replies
3/8ARM: hw_breakpoint: correct and simplify alignment fixup codearch/arm/kernel/hw_breakpoint.c+31 -250 replies
4/8ARM: hw_breakpoint: disable preemption during debug exception handlingarch/arm/kernel/entry-armv.S arch/arm/kernel/entry-header.S arch/arm/kernel/hw_breakpoint.c+32 -50 replies
5/8ARM: hw_breakpoint: don't advertise reserved breakpointsarch/arm/kernel/hw_breakpoint.c+116 -891 reply
5/8ARM: hw_breakpoint: don't advertise reserved breakpoints+0 -01 reply
5/8ARM: hw_breakpoint: don't advertise reserved breakpoints+0 -00 replies
6/8ARM: hw_breakpoint: do not allocate new breakpoints with rcu_read_lock heldarch/arm/include/asm/hw_breakpoint.h arch/arm/kernel/hw_breakpoint.c+78 -580 replies
7/8ARM: ptrace: fix style issue with hw_breakpoint interfacearch/arm/kernel/ptrace.c+2 -20 replies
8/8ARM: hw_breakpoint: fix warnings generated by sparsearch/arm/kernel/hw_breakpoint.c+13 -70 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchCatalin Marinas
1/8
2/8
3/8
4/8A-b
5/8
5/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] ARM: hw_breakpoint: fixes and improvements (v2)

Hello,

This is version 2 of the patchset originally posted here:

http://lists.infradead.org/pipermail/linux-arm-kernel/2010-November/032717.html

There are a substantial number of changes:

* Support for CONFIG_PREEMPT kernels.

* Hugely improved watchpoint single-step capabilities without violating RCU requirements.

* sparse no longer generates warnings for hw_breakpoint.c.

* We no longer advertise reserved breakpoints to GDB.

All feedback welcome. I would especially value feedback on patch [4/8] (`disable preemption during debug exception handling') to know if there's a better solution.

Will Deacon (8):
ARM: hw_breakpoint: ensure OS lock is clear before writing to debug
registers
ARM: hw_breakpoint: reset control registers in hotplug path
ARM: hw_breakpoint: correct and simplify alignment fixup code
ARM: hw_breakpoint: disable preemption during debug exception
handling
ARM: hw_breakpoint: don't advertise reserved breakpoints
ARM: hw_breakpoint: do not allocate new breakpoints with
rcu_read_lock held
ARM: ptrace: fix style issue with hw_breakpoint interface
ARM: hw_breakpoint: fix warnings generated by sparse

 arch/arm/include/asm/hw_breakpoint.h |    2 +-
 arch/arm/kernel/entry-armv.S         |    4 +
 arch/arm/kernel/entry-header.S       |   19 ++
 arch/arm/kernel/hw_breakpoint.c      |  464 ++++++++++++++++++++--------------
 arch/arm/kernel/ptrace.c             |    4 +-
 5 files changed, 305 insertions(+), 188 deletions(-)