Skip to content

bonding fixes

Ben Hutchings netdev 1 version In review

Get series with b4
b4 am 1292264216.9860.11.camel@bwh-desktop

Versions newest first

  1. v1 Latest3 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bonding/vlan: Remove redundant VLAN tag insertion logicdrivers/net/bonding/bond_main.c+1 -262 replies
2/3bonding: Change active slave quietly when bond is downdrivers/net/bonding/bond_main.c+9 -63 replies
3/3bonding/vlan: Fix mangled NAs on slaves without VLAN tag insertiondrivers/net/bonding/bond_ipv6.c+6 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJesse GrossFlavio Leitner
1/3R-b
2/3A-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next-2.6 0/3] bonding fixes

I've been investigating a bonding bug that results in skb_under_panic() on older kernels. The bug is still present but with less disastrous results. In the course of my investigation I found two regressions without actually looking very hard, which is somewhat worrying.

The fixes are:

1. Remove redundant VLAN tag insertion logic. Fixes a regression due to VLAN handling changes in 2.6.37, which corrupts *all* outgoing traffic on a VLAN over a bond when the slave does not implement VLAN tag insertion.

2. Change active slave quietly when bond is down. Fixes a crash introduced by 5a37e8ca8536c47871d46c82211f399adf06fd44 (bonding: rejoin multicast groups on VLANs) and also cleans up existing code.

3. Fix mangled NAs on slaves without VLAN tag insertion. This bug appears to have been present ever since gratuitous NAs were implemented in 2.6.29. It doesn't look possible to fix without relying on the recent VLAN handling changes. For stable/longterm and backports, I think the safest thing to do is not to send a gratuitous NA if it would end up mangled.

Ben.

Ben Hutchings (3):
bonding/vlan: Remove redundant VLAN tag insertion logic
bonding: Change active slave quietly when bond is down bonding/vlan: Fix mangled NAs on slaves without VLAN tag insertion

 drivers/net/bonding/bond_ipv6.c |    7 +++++-
 drivers/net/bonding/bond_main.c |   42 +++++++++-----------------------------
 2 files changed, 16 insertions(+), 33 deletions(-)
Signature · 7 lines
1.7.3.2


-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.