Skip to content

Introduce CLOCK_BOOTTIME (v2)

John Stultz lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hrtimers: extend hrtimer base code to handle more then 2 clockidsinclude/linux/hrtimer.h kernel/hrtimer.c+40 -140 replies
2/2hrtimers: Add CLOCK_BOOTTIME clockid, hrtimerbase and posix interfaceinclude/linux/hrtimer.h include/linux/time.h kernel/hrtimer.c +2 more+112 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Introduce CLOCK_BOOTTIME (v2)

After some discussions with Jamie Lokier about some of the drawbacks of CLOCK_MONOTONIC not incrementing during suspend (see http://www.spinics.net/lists/linux-fsdevel/msg40272.html),
I wanted to see if we couldn't provide a new clockid that would allow applications that wanted to be aware of time passing during suspend without having to deal with the inconsistencies of CLOCK_REALTIME caused by calls to settimeofday.

So this patchset introduces CLOCK_BOOTTIME, which is identical to CLOCK_MONOTONIC, but includes any time spent in suspend.

This second version of the patch uses a array table for the clock_id->hrtimer_base convesion instead of the switch.

Thomas: I've not been able to do much comparision at the asm level for ppc and arm (while I have cross tools for compiling, I don't have objdump for those arches on my build box) between this and the previous switch code. But on x86, size breakdown looks like:

Original:
text data bss dec hex filename
15517512 1899836 891200 18308548 1175dc4 vmlinux

Switch:
text data bss dec hex filename
15517716 1899804 891200 18308720 1175e70 vmlinux

Table:
text data bss dec hex filename
15517873 1899868 891200 18308941 1175f4d vmlinux

So that's not as great, but remvoing the WARN_ON added in hrtimer_clockid_to_base drops it down quite a bit:
Table-nowarn:
text data bss dec hex filename
15517617 1899804 891200 18308621 1175e0d vmlinux

Looking at the asm, the change from the original is limited (as expected)to: hrtimer_get_res, hrtimer_init, __hrtimer_start_range_ns, where the difference is a few extra movs, and and hrtimers_init, where there's the extra table initialization work.

If you have any tips for more specific comprisions please let me know. Diffing objdump output doesn't always make it super clear as to what changed.

Jamie: On platforms that don't implement read_persistent_clock, your issue would still be present, but fixing that is on my list. Other then that issue, does this seem to address your concern?

Arve: I believe CLOCK_BOOTTIME would be sufficient for what Android is using as elapsedRealtime() or ANDROID_ALARM_ELAPSED_REALTIME. If not please let me know why.

thanks
-john

CC Jamie Lokier <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Alexander Shishkin <[email protected]>
CC Arve Hjnnevg <[email protected]>

John Stultz (2):
[RFC] hrtimers: extend hrtimer base code to handle more then 2
clockids
[RFC] hrtimers: Add CLOCK_BOOTTIME clockid, hrtimerbase and posix
interface

 include/linux/hrtimer.h   |    8 ++++-
 include/linux/time.h      |    4 ++
 kernel/hrtimer.c          |   63 +++++++++++++++++++++++++++--------
 kernel/posix-timers.c     |   16 ++++++++-
 kernel/time/timekeeping.c |   79 ++++++++++++++++++++++++++++++++++++++++++++-
 5 files changed, 152 insertions(+), 18 deletions(-)
Signature · 1 line
1.7.3.2.146.gca209