Skip to content

percpu_counter: modifications to __percpu_counter_add_unless_lt()

Alex Elder linux-xfs 1 version In review

Get series with b4
b4 am 1293076567.2408.424.camel@doink

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5percpu_counter: fix test in __percpu_counter_add_unless_lt()lib/percpu_counter.c+3 -34 replies
2/5percpu_counter: avoid potential underflow in add_unless_ltlib/percpu_counter.c+8 -32 replies
3/5percpu_counter: fix error bound used in add_unless_lt functionlib/percpu_counter.c+3 -20 replies
4/5percpu_counter: tie error bounds more obviously to count valueslib/percpu_counter.c+23 -90 replies
5/5percpu_counter: only disable preemption if needed in add_unless_lt()lib/percpu_counter.c+10 -112 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] percpu_counter: modifications to __percpu_counter_add_unless_lt()

This series is based on (i.e., applies on top of) the third patch in Dave Chinner's scalability series (lib: percpu counter add unless less than functionality). I had some questions while reviewing that patch, and after closer inspection I think I found what I think are some problems, and in order to work through them I came up with this patch series to lay out what I think the problems are and my attempt at addressing them.

The series has been rearranged a bit since I put it together. Patch 3 includes some background and terminology that might be more useful at the beginning, but I'm leaving it as-is for now.

The more I look at the end result of the series the more confident I am that it's correct. However I still need some convincing--either to point out where I've got something wrong, or to affirm that what I have is right.

-Alex

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs