Cleanup ADJ_SETOFFSET patch
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | time: Introduce timekeeping_inject_offsetinclude/ kernel/ | +37 | 0 replies | |
| 2/3 | ntp: add ADJ_SETOFFSET mode bitinclude/ kernel/ | +28 | 7 replies | |
| 3/3 | ntp: Change ADJ_SETOFFSET implementation to use timekeeping_inject_offsetkernel/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Cleanup ADJ_SETOFFSET patch
I was looking to queue Richard's ADJ_SETOFFSET patch to see if it could be merged into -tip for 2.6.38, but on second glance I noticed the ugly local_irq_disable bits as well as the fact that adding the offset uses a gettime/add/settime pattern which will also add a small error as the action isn't atomic.
So I implemented a timekeeping function to add a fixed offset:timekeeping_inject_offset(), and reworked Richard's code to make use of it.
Richard: Any objection here? Mind testing this with the rest of your patch queue?
Thomas: Any comments? Does this seem reasonable for 2.6.38? Should I fold my cleanups into Richard's patch?
thanks
-john
John Stultz (2):
time: Introduce timekeeping_inject_offset
ntp: Change ADJ_SETOFFSET implementation to use
timekeeping_inject_offset
Richard Cochran (1):
ntp: add ADJ_SETOFFSET mode bit
include/linux/time.h | 1 + include/linux/timex.h | 3 ++- kernel/time/ntp.c | 13 +++++++++++++ kernel/time/timekeeping.c | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 52 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.3.2.146.gca209