KVM test: replace 'env' dict with an Env object
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | KVM test: introduce the Env classclient/ | +85 | 0 replies | |
| 2/4 | KVM test: use kvm_utils.Env wherever appropriateclient/ client/ | +7 | 0 replies | |
| 3/4 | KVM test: use the new Env methods instead of the old env_* functionsclient/ client/ client/ +7 more | +19 | 0 replies | |
| 4/4 | KVM test: get rid of the kvm_utils.env_* functionsclient/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [KVM-AUTOTEST PATCH 0/4] KVM test: replace 'env' dict with an Env object
This is a respin of Eduardo's patchset with small modifications.
Differences from Eduardo's patches:
- These patches don't change the module structure of the KVM test (no kvm package is created). We can still do that in the future if we choose to.
- The class is named Env instead of KvmEnv.
- It's defined in kvm_utils.py instead of a module of its own.
- No unittests for Env. I personally don't think they're necessary, nor do I think anyone will bother to use them, but let me know if you disagree.
- The __init__() method takes care of the loading if a filename is provided.
- save() can do what _dump() did, so _dump() is unnecessary.
- The series is a lot shorter and will hopefully be easier to review.
Michael Goldish (4):
KVM test: introduce the Env class
KVM test: use kvm_utils.Env wherever appropriate
KVM test: use the new Env methods instead of the old env_* functions KVM test: get rid of the kvm_utils.env_* functions
client/tests/kvm/kvm.py | 12 +- client/tests/kvm/kvm_preprocessing.py | 12 +- client/tests/kvm/kvm_scheduler.py | 4 +- client/tests/kvm/kvm_test_utils.py | 4 +- client/tests/kvm/kvm_utils.py | 165 +++++++++++++++-------------- client/tests/kvm/tests/ksm_overcommit.py | 4 +- client/tests/kvm/tests/qemu_img.py | 6 +- client/tests/kvm/tests/stepmaker.py | 2 +- client/tests/kvm/tests/steps.py | 2 +- client/tests/kvm/tests/stress_boot.py | 2 +- client/tests/kvm/tests/unittest.py | 2 +- client/tests/kvm/tests/virtio_console.py | 2 +- 12 files changed, 111 insertions(+), 106 deletions(-)
Signature · 1 line
1.7.3.4