Skip to content

: patch set to update the git reference policy

Guido Trentalancia selinux-refpolicy 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 19 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 19 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [refpolicy] [PATCH/RFC 0/19]: patch set to update the git reference policy

Hello Martin !

Thanks very much for your interest in this attempt to feed back some possible improvements to the reference policy based upon testing on a generic recent installation.

Quoted 13 lines · Martin Orr
Quoted 11 lines · Guido Trentalancia
Quoted 4 lines · Christopher J. PeBenito

One thing I want to clarify for each of the actual patches you need:

* a better subject: "patch set to update the git reference policy" isn't very informative.

Then, it would probably be impossible to submit a patch set at all. We will just have many individual, separate patches. Because the whole patch set aims to tackle very different issues in many different places that it would probably be impossible to summarize everything in the subject.

Quoted 5 lines

I think this is the point: because you deal with many different issues, you do not really have a "set". Chris can decide independently for each of the patches whether to apply it or not, and that will (usually) not break and will cause a measurable improvement in refpolicy.

I will do my best. However, I am not entirely sure (and cannot guarantee) that applying only a subset of the patches will lead to desirable results. In general, they will be made as much independent from each other as technically possible.

Quoted 5 lines

The subject of each patch should be a short summary of what that individual patch does, for example "dbus file labelling" for patch 1 and "Allow dbus messages" for patch 2. If you can't give such a label to a particular patch, that might mean that you have divided up your patches badly.

Yes, I will re-submit individual, disjoint patches so that each message has a different subject. A short textual description at the beginning of each message will summarize the aims of the patch that follows.

Quoted 11 lines
Quoted 11 lines
Quoted 1 line

* a detailed description of what the patch does.

Sure. It will be done.

Quoted 2 lines

This will help facilitate review of the patches, and will help us understand the details.

In general, the set of patches is the result of testing refpolicy on a very recent generic Linux installation. It aims to fix generic issues with a few essential modules while trying to use the latest refpolicy on a recent unbranded Linux installation.

In general, it's just several tiny adjustments to some permissions in a bunch of modules that I have tested. Something else might come at a later time if I manage to test other modules or write new modules.

In the meanwhile, should you have other comments or questions to raise, please do not hesitate to contact me.

Kind regards,

Guido