Skip to content

perf: offcore event monitoring patches

Lin Ming lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 7 repliesIn review
  2. v24 patches 6 repliesSuperseded
  3. v16 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Remove redundant "c = NULL" in intel_percore_constraints
- Fix comment of perf_event_attr::config1

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf: Add support for supplementary event registersarch/x86/include/asm/msr-index.h arch/x86/kernel/cpu/perf_event.c arch/x86/kernel/cpu/perf_event_intel.c +1 more+278 -21 reply
2/4perf: Fix LLC-* events on Intel Nehalem/Westmerearch/x86/kernel/cpu/perf_event.c arch/x86/kernel/cpu/perf_event_intel.c+79 -172 replies
3/4perf: Add support to the perf tool to specify extra valuestools/perf/builtin-report.c tools/perf/util/parse-events.c tools/perf/util/parse-events.h +1 more+26 -100 replies
4/4perf: Avoid the percore allocations if HT is not capablearch/x86/kernel/cpu/perf_event_intel.c+17 -62 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] perf: offcore event monitoring patches

Hi,

v2 -> v3:
- Remove redundant "c = NULL" in intel_percore_constraints
- Fix comment of perf_event_attr::config1

v2:
Here is the updated offcore patches. I merged small changes and fixes into the first patch, see the change logs.

Change logs against Andi's original version:
- Extends perf_event_attr:config to config{,1,2} (Peter Zijlstra)
- Fixed a major event scheduling issue. There cannot be a ref++ on an event that has already done ref++ once and without calling put_constraint() in between. (Stephane Eranian)
- Use thread_cpumask for percore allocation. (Lin Ming)
- Use MSR names in the extra reg lists. (Lin Ming)

Peter,
The event scheduling issue was fixed, could you please consider merging this series?

Thanks,
Lin Ming