Add --version option and fix some bugs in show_usage()
Get series with b4
b4 am 1298315809.2608.68.camel@bwh-desktopVersions newest first
- v1 Latest5 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ethtool: Split show_usage() into two functionsethtool.c | +73 | 0 replies | |
| 2/5 | ethtool: Report an error if given an unrecognised optionethtool.c | +3 | 0 replies | |
| 3/5 | ethtool: Allow for long options with no short option and without a device nameethtool.c | +14 | 0 replies | |
| 4/5 | ethtool: Indent the no-options usage line consistently with the othersethtool.c | +2 | 0 replies | |
| 5/5 | ethtool: Add --version optionethtool.8.in ethtool.c | +11 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH ethtool 0/5] Add --version option and fix some bugs in show_usage()
Every command-line tool needs a --version option, right? And while looking at the existing option parsing and usage messages I found and fixed some bugs.
Ben.
Ben Hutchings (5):
ethtool: Split show_usage() into two functions
ethtool: Report an error if given an unrecognised option
ethtool: Allow for long options with no short option and without a
device name
ethtool: Indent the no-options usage line consistently with the
others
ethtool: Add --version option
ethtool.8.in | 5 ++ ethtool.c | 165 +++++++++++++++++++++++++++++++-------------------------- 2 files changed, 95 insertions(+), 75 deletions(-)
Signature · 7 lines
1.7.3.4 -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.