pxa3xx_nand update series set version 4
Get series with b4
b4 am 1298630371.2798.43.camel@localhostVersions newest first
- v4 Latest0 of 6 patches 0 repliesNew
Patches in v4 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH V4 0/6] pxa3xx_nand update series set version 4
Quoted 11 lines · Lei Wen
Change from previous version:
rework the patch set accroding to Eric's suggestion. Move the recode judgement to the after command execution.Lei Wen (6):
pxa3xx_nand: make scan procedure more clear
pxa3xx_nand: rework irq logic
pxa3xx_nand: discard wait_for_event,write_cmd,__readid function
pxa3xx_nand: unify prepare command
pxa3xx_nand: mtd scan id process could be defined by driver itself
pxa3xx_nand: clean the keep configure code
Hi, could you please make checkpatch.pl happy and re-send the patches?
There are many issues. OK, some are fine, do not try to fix them, e.g.:
WARNING: line over 80 characters
#127: FILE: drivers/mtd/nand/pxa3xx_nand.c:221:
+{ "512MiB 16-bit", 0xcc2c, 64, 2048, 16, 16, 4096, &default_cmdset, &timing[2] },
but some are clearly stylistic errors:
ERROR: else should follow close brace '}'
#249: FILE: drivers/mtd/nand/pxa3xx_nand.c:539:
+ }
+ else {
etc.
Thanks!
Signature · 2 lines
Best Regards, Artem Bityutskiy (????? ????????)