Skip to content

x86 idle cruft removal - v2

Len Brown linux-pm lkml xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 42 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9x86 idle: remove "no-hlt" cmdline paramDocumentation/kernel-parameters.txt arch/x86/kernel/cpu/bugs.c+0 -120 replies
1/9x86 idle: remove "no-hlt" cmdline paramDocumentation/kernel-parameters.txt arch/x86/kernel/cpu/bugs.c+0 -120 replies
2/9x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flagarch/x86/include/asm/processor.h arch/x86/kernel/cpu/bugs.c arch/x86/kernel/cpu/proc.c +3 more+4 -170 replies
2/9x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flagarch/x86/include/asm/processor.h arch/x86/kernel/cpu/bugs.c arch/x86/kernel/cpu/proc.c +3 more+4 -1724 replies
3/9x86 idle: remove NOP halt_works()arch/x86/include/asm/processor.h arch/x86/kernel/process.c+1 -70 replies
3/9x86 idle: remove NOP halt_works()arch/x86/include/asm/processor.h arch/x86/kernel/process.c+1 -70 replies
4/9x86 idle floppy: delete disable_hlt()/enable_hlt()arch/x86/include/asm/system.h arch/x86/kernel/process.c drivers/block/floppy.c+0 -660 replies
4/9x86 idle floppy: delete disable_hlt()/enable_hlt()arch/x86/include/asm/system.h arch/x86/kernel/process.c drivers/block/floppy.c+0 -660 replies
5/9x86 idle: remove NOP hlt_use_halt()arch/x86/kernel/process.c+14 -250 replies
5/9x86 idle: remove NOP hlt_use_halt()arch/x86/kernel/process.c+14 -250 replies
6/9x86 idle APM: delete apm_cpu_idle(), and its use of (pm_idle)()arch/x86/Kconfig arch/x86/kernel/apm_32.c+0 -2430 replies
6/9x86 idle APM: delete apm_cpu_idle(), and its use of (pm_idle)()arch/x86/Kconfig arch/x86/kernel/apm_32.c+0 -2430 replies
7/9x86 idle: do not EXPORT_SYMBOL pm_idle and default_idlearch/x86/kernel/process.c+0 -40 replies
7/9x86 idle: do not EXPORT_SYMBOL pm_idle and default_idlearch/x86/kernel/process.c+0 -40 replies
8/9x86 idle: move mwait_idle_with_hints() to where it is usedarch/x86/include/asm/processor.h arch/x86/kernel/acpi/cstate.c arch/x86/kernel/process.c+24 -250 replies
8/9x86 idle: move mwait_idle_with_hints() to where it is usedarch/x86/include/asm/processor.h arch/x86/kernel/acpi/cstate.c arch/x86/kernel/process.c+24 -250 replies
9/9x86 idle: delete mwait_idle()Documentation/kernel-parameters.txt arch/x86/include/asm/processor.h arch/x86/kernel/process.c +1 more+3 -410 replies
9/9x86 idle: delete mwait_idle()Documentation/kernel-parameters.txt arch/x86/include/asm/processor.h arch/x86/kernel/process.c +1 more+3 -412 replies

Reviews trailers per patch

2 of 18 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndreas HerrmannIngo MolnarJiri KosinaBorislav Petkov
SeriesA-b A-b A-b A-b A-b A-b A-b A-b
1/9
1/9
2/9
2/9
3/9
3/9
4/9
4/9
5/9
5/9
6/9
6/9
7/9
7/9
8/9
8/9
9/9A-b A-b
9/9A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] x86 idle cruft removal - v2

unchanged:

[PATCH 1/9] x86 idle: remove "no-hlt" cmdline param [PATCH 2/9] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag [PATCH 3/9] x86 idle: remove NOP halt_works()
[PATCH 4/9] x86 idle floppy: delete disable_hlt()/enable_hlt() [PATCH 5/9] x86 idle: remove NOP hlt_use_halt()

new:

[PATCH 6/9] x86 idle APM: delete apm_cpu_idle(), and its use of pm_idle [PATCH 7/9] x86 idle: do not EXPORT_SYMBOL pm_idle and default_idle [PATCH 8/9] x86 idle: move mwait_idle_with_hints() to where it is used [PATCH 9/9] x86 idle: delete mwait_idle()

 Documentation/kernel-parameters.txt |   11 +--
 arch/x86/Kconfig                    |   11 --
 arch/x86/include/asm/processor.h    |   14 +--
 arch/x86/include/asm/system.h       |    7 -
 arch/x86/kernel/acpi/cstate.c       |   24 ++++
 arch/x86/kernel/apm_32.c            |  232 -----------------------------------
 arch/x86/kernel/cpu/bugs.c          |   13 +--
 arch/x86/kernel/cpu/proc.c          |    2 -
 arch/x86/kernel/process.c           |  127 +++-----------------
 arch/x86/kernel/setup.c             |    4 +-
 arch/x86/xen/setup.c                |    3 -
 drivers/acpi/processor_idle.c       |    1 -
 drivers/block/floppy.c              |   35 ------
 13 files changed, 45 insertions(+), 439 deletions(-)

What is next:

handle c1e_idle() vs default_idle()
run-time check for AMD workaround enable as part of default_idle?
give xen_arch_setup default_idle() w/o having it touch pm_idle
perhaps it can simply set a flag to disable cpuidle...
which is what would run if the xen kernel were booted on raw iron. Or can we handle this
at compile time?
delete pm_idle
x86 will then use default_idle or cpuidle
allow cpuidle to use default_idle to handle the period
where it polls because cpus have not yet registered