Skip to content

Updates to --tmp-dir patch

David Sommerseth openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Make use of $TMPDIR on non-Windowsconfigure.ac options.c+5 -131 reply
2/2Use %SystemRoot% instead of hard-coded C:\WINDOWS for temp directory pathwin/config.h.in win32.c+26 -135 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/2] Updates to --tmp-dir patch

These patches goes on-top of the previous --tmp-dir patch [1].

In summary, these patches implement the consensus of the following discussion.

* Remove compile time configuration option for default temp dir. In non-Windows environments it is most likely that /tmp will exist anyway. For Windows environments it is now using %SystemRoot%\Temp as the last fallback possibility. If this fails, it is most likely that there are more sever issues which is not related to OpenVPN at all.

* Check for $TMPDIR
In non-Windows environments, the $TMPDIR directory may be used to set a specific temporary directory path. If this is not found, /tmp will be used as the default. Nothing has changed in this regard for Windows environments, where %TEMP% and %TMP% are checked before the fallback.

Kind regards,

David Sommerseth

[1] <http://thread.gmane.org/gmane.network.openvpn.devel/4561>

David Sommerseth (2):
Make use of $TMPDIR on non-Windows
Use %SystemRoot% instead of hard-coded C:\WINDOWS for temp directory
path

 configure.ac    |   11 -----------
 options.c       |    7 +++++--
 win/config.h.in |    3 ---
 win32.c         |   36 ++++++++++++++++++++++++++----------
 4 files changed, 31 insertions(+), 26 deletions(-)
Signature · 1 line
1.7.4.2