RFC Fix Thumb-2 undef handling for mixed-arch kernels
Get series with b4
b4 am 1312975897.7800.20.camel@computer2Versions newest first
- v1 RFC Latest3 of 5 patches 0 repliesNew
3 of 5 patches are in this archive. The cover letter announces 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ARM: Make cpu_alignment into a global variable | +0 | 0 replies | |
| 3/5 | ARM: kprobes: Reference cpu_architecture as a global variable | +0 | 0 replies | |
| 5/5 | ARM: entry: Fix Thumb-2 undef handling for multi-CPU kernels | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/5] Fix Thumb-2 undef handling for mixed-arch kernels
Quoted 3 lines · Dave Martin
As a side-effect, this also changes
cpu_architecturefrom a function into a global variable initialised at boot-time, which is probably a sensible idea anyway.
One possible pitfall of this is if the variable didn't get set up before it's first use. I have looked at all the uses and this doesn't seem to be a problem though.
An alternative to defend against this is to make cpu_architecture() an inline function returning the value of the global variable like:
inline int cpu_architecture(void)
{
BUG_ON(the_cpu_architecture == CPU_ARCH_UNKNOWN);
return the_cpu_architecture;
}This has the bonus of not needing to change users of the the function.
Signature · 1 line
Tixy