Staging: cx25821: Fix style issues

Leonid V. Fedorenchik lkml 4 versions Aug 14, 2011 – Sep 2, 2011 In review

Get series with b4

b4 am [email protected]

Versions newest first · linked by author and title

v4 Latest Sep 2, 201119 patches 6 repliesIn review
v3 Aug 30, 201118 patches 6 repliesSuperseded
v2 Aug 15, 20113 patches 2 repliesSuperseded

Earlier versions · 1

Version	Posted	Patches	Replies	Status
v1	Aug 14, 2011	3 patches	1 reply	Superseded

Patches in v4 No applies recorded yet

#	Subject and files	Size	Replies
1/19	Staging: cx25821: Get rid of typedef in cx25821.h`drivers/staging/cx25821/cx25821.h`	+5 -3	0 replies
2/19	Staging: cx25821: Rename member name in struct cx25821_dev`drivers/staging/cx25821/cx25821-audio-upstream.c` `drivers/staging/cx25821/cx25821.h`	+6 -6	0 replies
3/19	Staging: cx25821: Delete file cx25821-gpio.h`drivers/staging/cx25821/cx25821-gpio.h`	+0 -2	0 replies
4/19	Staging: cx25821: Move EXPORT_SYMBOL() to the right place`drivers/staging/cx25821/cx25821-core.c` `drivers/staging/cx25821/cx25821-gpio.c`	+1 -1	0 replies
5/19	Staging: cx25821: Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl`drivers/staging/cx25821/cx25821-core.c`	+1 -1	0 replies
6/19	Staging: cx25821: Fix wrong statement indent in cx25821-cards.c`drivers/staging/cx25821/cx25821-cards.c`	+13 ~~-13~~	0 replies
7/19	Staging: cx25821: Fix wrong statement indent in cx25821-core.c`drivers/staging/cx25821/cx25821-core.c`	+250 ~~-250~~	0 replies
8/19	Staging: cx25821: Fix wrong statement indent in cx25821-i2c.c`drivers/staging/cx25821/cx25821-i2c.c`	+15 ~~-15~~	0 replies
9/19	Staging: cx25821: Fix too long lines in cx25821-audio.h`drivers/staging/cx25821/cx25821-audio.h`	+4 -2	0 replies
10/19	Staging: cx25821: Fix obscure line endings in cx25821-audio-upstream.c`drivers/staging/cx25821/cx25821-audio-upstream.c`	+9 ~~-16~~	0 replies
11/19	Staging: cx25821: Fix long lines in cx25821-audio-upstream.c`drivers/staging/cx25821/cx25821-audio-upstream.c`	+3 -7	0 replies
12/19	Staging: cx25821: Fix long lines in cx25821-audio-upstream.h`drivers/staging/cx25821/cx25821-audio-upstream.h`	+7 -2	0 replies
13/19	Staging: cx25821: Replace :? by if-else in cx25821-video-upstream-ch2.c`drivers/staging/cx25821/cx25821-video-upstream-ch2.c`	+12 ~~-11~~	0 replies
14/19	Staging: cx25821: Fix labels' placement in cx25821-video-upstream-ch2.c`drivers/staging/cx25821/cx25821-video-upstream-ch2.c`	+3 -3	0 replies
15/19	Staging: cx25821: Fix wrong line endings in cx25821-video-upstream-ch2.c`drivers/staging/cx25821/cx25821-video-upstream-ch2.c`	+9 ~~-15~~	0 replies
16/19	Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.c`drivers/staging/cx25821/cx25821-video-upstream-ch2.c`	+9 ~~-17~~	0 replies
17/19	Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.h`drivers/staging/cx25821/cx25821-video-upstream-ch2.h`	+60 ~~-23~~	0 replies
18/19	Staging: cx25821: Fix long lines in cx25821-video-upstream.c`drivers/staging/cx25821/cx25821-video-upstream.c`	+6 ~~-10~~	0 replies
19/19	Staging: cx25821: Fix long lines in cx25821-video-upstream.h`drivers/staging/cx25821/cx25821-video-upstream.h`	+54 ~~-24~~	0 replies

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

Patch	Dan Carpenter	Valdis Kletnieks
Series	R-b	R-b
1/19
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/19] Staging: cx25821: Fix style issues

This patch series fixes some style issues in drivers/staging/cx25821

I split my previous patches per logical change and combined them into one patch series.

Changes in v4 based on reviews of v3.

Leonid V. Fedorenchik (19):
Staging: cx25821: Get rid of typedef in cx25821.h
Staging: cx25821: Rename member name in struct cx25821_dev
Staging: cx25821: Delete file cx25821-gpio.h
Staging: cx25821: Move EXPORT_SYMBOL() to the right place
Staging: cx25821: Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl
Staging: cx25821: Fix wrong statement indent in cx25821-cards.c
Staging: cx25821: Fix wrong statement indent in cx25821-core.c
Staging: cx25821: Fix wrong statement indent in cx25821-i2c.c
Staging: cx25821: Fix too long lines in cx25821-audio.h
Staging: cx25821: Fix obscure line endings in cx25821-audio-upstream.c
Staging: cx25821: Fix long lines in cx25821-audio-upstream.c
Staging: cx25821: Fix long lines in cx25821-audio-upstream.h
Staging: cx25821: Replace :? by if-else in cx25821-video-upstream-ch2.c
Staging: cx25821: Fix labels' placement in cx25821-video-upstream-ch2.c
Staging: cx25821: Fix wrong line endings in cx25821-video-upstream-ch2.c
Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.c
Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.h
Staging: cx25821: Fix long lines in cx25821-video-upstream.c
Staging: cx25821: Fix long lines in cx25821-video-upstream.h

 drivers/staging/cx25821/cx25821-audio-upstream.c   |   41 +-
 drivers/staging/cx25821/cx25821-audio-upstream.h   |    9 +-
 drivers/staging/cx25821/cx25821-audio.h            |    6 +-
 drivers/staging/cx25821/cx25821-cards.c            |   26 +-
 drivers/staging/cx25821/cx25821-core.c             |  503 ++++++++++----------
 drivers/staging/cx25821/cx25821-gpio.c             |    1 +
 drivers/staging/cx25821/cx25821-gpio.h             |    2 -
 drivers/staging/cx25821/cx25821-i2c.c              |   30 +-
 .../staging/cx25821/cx25821-video-upstream-ch2.c   |   79 ++--
 .../staging/cx25821/cx25821-video-upstream-ch2.h   |   83 +++-
 drivers/staging/cx25821/cx25821-video-upstream.c   |   16 +-
 drivers/staging/cx25821/cx25821-video-upstream.h   |   78 +++-
 drivers/staging/cx25821/cx25821.h                  |   10 +-
 13 files changed, 465 insertions(+), 419 deletions(-)
 delete mode 100644 drivers/staging/cx25821/cx25821-gpio.h

Read the cover letter in its thread