Skip to content

RFC for snd-usb: rework usb endpoint logic

Daniel Mack alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 28 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ALSA: snd-usb: implement new endpoint streaming modelsound/usb/card.h sound/usb/endpoint.c sound/usb/endpoint.h +1 more+882 -117 replies
2/5ALSA: snd-usb: switch over to new endpoint streaming logicsound/usb/card.c sound/usb/card.h sound/usb/endpoint.c +3 more+369 -1187 replies
3/5ALSA: snd-usb: remove old streaming logicsound/usb/endpoint.c sound/usb/endpoint.h+41 -8910 replies
4/5ALSA: snd-usb: set MAX_URBS to 16sound/usb/card.h+1 -11 reply
5/5ALSA: snd-usb: add support for implicit feedbacksound/usb/pcm.c+10 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] RFC for snd-usb: rework usb endpoint logic

It's been a while since the last round of patches for this topic, so here is a new version.

In contrast to earlier versions, I did another bunch of cleanips and can now use input and output simultaniously.

The patches that follow are structured in a way that should make reviews easier, as they first implement a new streaming model while leaving the old one working, and then switch to it in a separate patch. This way, the series is also fully bisectable.

The problems that remain is a regression in handling data streams with feedback endpoints in full duplex mode and a hard lockup when changing audio parameters while two streams are running. I guess the latter is caused by missing locking.

I didn't sign-off the patches on purpose, as I would really like to get them reviewed before they go in. Can people have a look and state whether the whole idea is at all sane?

Thanks a lot,
Daniel

Daniel Mack (5):
ALSA: snd-usb: implement new endpoint streaming model
ALSA: snd-usb: switch over to new endpoint streaming logic
ALSA: snd-usb: remove old streaming logic
ALSA: snd-usb: set MAX_URBS to 16
ALSA: snd-usb: add support for implicit feedback

 sound/usb/card.c     |    6 +-
 sound/usb/card.h     |   56 ++-
 sound/usb/endpoint.c | 1347 ++++++++++++++++++++++++--------------------------
 sound/usb/endpoint.h |   31 +-
 sound/usb/pcm.c      |  412 +++++++++++++---
 sound/usb/stream.c   |   31 +-
 sound/usb/usbaudio.h |    1 +
 7 files changed, 1081 insertions(+), 803 deletions(-)
Signature · 1 line
1.7.5.4