Skip to content

Check for resized smaller devices, v1, rhbz753914

Dave Wysochanski lvm-devel 1 version New

Get series with b4
b4 am 1321366292.1790.27.camel@f14-work

Versions newest first

  1. v1 Latest0 of 5 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Check for resized smaller devices, v1, rhbz753914
Quoted 5 lines · Alasdair G Kergon

There are circumstances where sizes don't match and it's OK. There are circumstances where sizes don't match and it's not OK.

Warn, prompt or abort?

"sizes don't match" is a larger scope than what I was trying to tackle.

I don't think pv_size should ever be larger than dev_size, and today it causes strange failures with things like lvcreate.

However, it's perfectly fine for pv_size to be be smaller than dev_size (no LVM problems result).

Quoted 3 lines

vg_validate is really about the internal consistency of the metadata, and I hesitate to extend it to check the underlying devices.

Ok, that's reasonable to say vg_validate is restricted to internal checks. I was not sure exactly where we should call it.

Quoted 3 lines

It's not a particularly cheap check either. It shouldn't be done while any devices are suspended.

Yeah, and in probably 95% of times the check will pass so it's just overhead. This would argue for restricting the check to something like pvck or vgck.

What do you think about calling from pvck / vgck for now?

Quoted 4 lines

A flag in each PV to say to ignore a size mismatch on an individual PV, controlled with pvchange and set when --setphysicalvolumesize overrides it, or alternatively just a single global lvm.conf setting?

I would hope to not have to implement another flag or option but it may be necessary.

Quoted 4 lines

Cache the sizes during the standard scanning we already do, perhaps and then check on (just the first?) vg read? Re-check next time VG lock is acquired? (Hook into VG cache this way?)

I'll have to look into the scope of these types of changes. At a high level, it seems a reasonable approach, and may even improve performance.