snd-usb endpoint rework, take 5
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ALSA: snd-usb: add snd_usb_audio-wide mutexsound/ sound/ | +3 | 0 replies | |
| 2/5 | ALSA: snd-usb: implement new endpoint streaming modelsound/ sound/ sound/ +1 more | +1001 | 6 replies | |
| 3/5 | ALSA: snd-usb: switch over to new endpoint streaming logicsound/ sound/ sound/ +3 more | +381 | 0 replies | |
| 4/5 | ALSA: snd-usb: remove old streaming logicsound/ sound/ | +8 | 0 replies | |
| 5/5 | ALSA: snd-usb: add support for implicit feedbacksound/ | +26 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] snd-usb endpoint rework, take 5
I actually wanted to wait for more input, but as the flaws reported so far were rather minor, I addressed to following details in this new round as mentioned by Takashi and Clemens:
- removed the faulty "(!u || u->urb)" check
- guard the result of min() with the spinlock inside next_packet_size()
- removed the tasklet and made the handler a function that is called in-place
Thanks again for the reviews, and keep them coming :)
Daniel
Daniel Mack (5):
ALSA: snd-usb: add snd_usb_audio-wide mutex
ALSA: snd-usb: implement new endpoint streaming model
ALSA: snd-usb: switch over to new endpoint streaming logic
ALSA: snd-usb: remove old streaming logic
ALSA: snd-usb: add support for implicit feedback
sound/usb/card.c | 10 +- sound/usb/card.h | 62 +++ sound/usb/endpoint.c | 1454 +++++++++++++++++++++++++------------------------ sound/usb/endpoint.h | 32 +- sound/usb/pcm.c | 437 +++++++++++++--- sound/usb/stream.c | 31 +- sound/usb/usbaudio.h | 2 + 7 files changed, 1224 insertions(+), 804 deletions(-)
Signature · 1 line
1.7.5.4