Skip to content

misc cleanup patches

Arne Schwabe openvpn-devel 1 version Applied

Status from this message: Applied to master.

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest6 patches 10 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6Only use tmpdir if tmp_dir is really used.src/openvpn/options.c src/openvpn/options.h+8 -32 replies
2/6Completely remove ancient IANA port warning.src/openvpn/init.c src/openvpn/options.c src/openvpn/options.h+0 -102 replies
3/6Remove ENABLE_INLINE_FILES conditionals, this code is always enabled and removing the #ifdef make the code a little bit clearersrc/openvpn/common.h src/openvpn/crypto.c src/openvpn/init.c +7 more+23 -1423 replies
4/6Remove ENABLE_CONNECTIONS ifdefs, connections were always on for a long time. Not that ENABLE_MAMAGEMENT_REMOTE was only depending on ENABLE_CONNECTIONS and is removed as wellsrc/openvpn/init.c src/openvpn/manage.c src/openvpn/manage.h +3 more+1 -843 replies
5/6Fix most of the clang warnings, mostly unused variables and comparisons which were always truesrc/openvpn/crypto.c src/openvpn/mroute.c src/openvpn/multi.c +5 more+14 -330 replies
6/6Fix clang warnings for conversion from unsigned<->signedsrc/openvpn/httpdigest.c src/openvpn/ntlm.c+26 -260 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchGert Doering
1/6A-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/6] misc cleanup patches

A few clean up patches that I have local. Some of these might be useful in a 2.3 release.

Arne Schwabe (6):
Only use tmpdir if tmp_dir is really used.
Completely remove ancient IANA port warning.
Remove ENABLE_INLINE_FILES conditionals, this code is always enabled
and removing the #ifdef make the code a little bit clearer
Remove ENABLE_CONNECTIONS ifdefs, connections were always on for a
long time. Not that ENABLE_MAMAGEMENT_REMOTE was only depending
on ENABLE_CONNECTIONS and is removed as well
Fix most of the clang warnings, mostly unused variables and
comparisons which were always true
Fix clang warnings for conversion from unsigned<->signed

 src/openvpn/common.h             |    2 -
 src/openvpn/crypto.c             |    8 -----
 src/openvpn/httpdigest.c         |   44 ++++++++++++++--------------
 src/openvpn/init.c               |   22 --------------
 src/openvpn/manage.c             |    8 -----
 src/openvpn/manage.h             |    6 ----
 src/openvpn/misc.c               |    6 ----
 src/openvpn/mroute.c             |   28 +++++++----------
 src/openvpn/multi.c              |    7 +----
 src/openvpn/ntlm.c               |    8 ++--
 src/openvpn/options.c            |   60 +++----------------------------------
 src/openvpn/options.h            |   30 ++-----------------
 src/openvpn/route.c              |    1 -
 src/openvpn/ssl.c                |    4 --
 src/openvpn/ssl_backend.h        |   36 ++++++----------------
 src/openvpn/ssl_openssl.c        |   40 ++++---------------------
 src/openvpn/ssl_polarssl.c       |   34 ++++-----------------
 src/openvpn/ssl_verify_openssl.c |    2 +-
 src/openvpn/syshead.h            |   24 +--------------
 19 files changed, 72 insertions(+), 298 deletions(-)
Signature · 1 line
1.7.7.5 (Apple Git-26)