Skip to content

Cleanup patches

Arne Schwabe openvpn-devel 1 version Applied

Status from this message: Applied to master.

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest4 patches 15 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4Fixes error: --key fails with EXTERNAL_PRIVATE_KEY: No such file or directory if --management-external-key is usedsrc/openvpn/options.c+16 -20 replies
1/4Fixes error: --key fails with EXTERNAL_PRIVATE_KEY: No such file or directory if --management-external-key is usedsrc/openvpn/options.c+15 -22 replies
2/4Merge getaddr_multi and getaddr6 into one functionsrc/openvpn/route.c src/openvpn/socket.c src/openvpn/socket.h+215 -4349 replies
3/4Merge almost identical create_socket_tcp and create_socket_tcp6src/openvpn/manage.c src/openvpn/socket.c src/openvpn/socket.h+10 -492 replies
3/4Merge almost identical create_socket_tcp and create_socket_tcp6src/openvpn/manage.c src/openvpn/socket.c src/openvpn/socket.h+10 -492 replies
4/4Simplify print_sockaddr_ex function, merge duplicate ipv4/ipv6 logicsrc/openvpn/socket.c+39 -508 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/4] Cleanup patches

The first patch is a corrected (read working) version of the patch I posted a while ago.

For the last three patches. I am in the progress of looking through the socket.c code. The ultimate goal is to simplify the code and have good way of dealing with ipv4/ipv6 dual stack. These first patches don't change any functionality but clean up the code.

Arne Schwabe (4):
Fixes error: --key fails with EXTERNAL_PRIVATE_KEY: No such file or

    directory if  --management-external-key is used

Merge getaddr_multi and getaddr6 into one function
Merge almost identical create_socket_tcp and create_socket_tcp6 Simplify print_sockaddr_ex function, merge duplicate ipv4/ipv6 logic

 src/openvpn/manage.c  |    4 +-
 src/openvpn/options.c |   18 +-
 src/openvpn/route.c   |   50 ++--
 src/openvpn/socket.c  |  724 ++++++++++++++++---------------------------------
 src/openvpn/socket.h  |   19 +-
 5 files changed, 280 insertions(+), 535 deletions(-)
Signature · 1 line
1.7.9.6 (Apple Git-31.1)