Skip to content

slirp: tftp server improvements

Hervé Poussineau qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v23 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- removed patch 1/3, already applied to slirp queue
- updated with Jan Kiszka remarks

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2slirp: Handle more than 65535 blocks in TFTP transfersslirp/tftp.c slirp/tftp.h+11 -141 reply
2/2slirp: Implement TFTP Blocksize optionslirp/tftp.c+33 -93 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] slirp: tftp server improvements

These patches have already been sent in April 2011, and contain some fixes for the internal TFTP server. With these patches, MS Windows PE can be booted via PXE, and 32MB file limitation has been removed.

This has been tested with MS Windows 2003 PXE boot client, PXELINUX and gPXE.

Indentation seems a little bit off in patch 2/2, because surrounding code indentation is one tab followed by spaces. I've indented new lines by replacing the tab by 8 spaces. Patch 1/2 also has indentation errors reported by checkpatch.pl, but I kept indentation consistent.

Changes v1 -> v2
- rebased
- updated with Aurélien Jarno remarks
- improved commit messages

Changes v2 -> v3
- removed patch 1/3, already applied to slirp queue
- updated with Jan Kiszka remarks

Hervé Poussineau (2):
slirp: Handle more than 65535 blocks in TFTP transfers
slirp: Implement TFTP Blocksize option

 slirp/tftp.c |   66 ++++++++++++++++++++++++++++++++++++++--------------------
 slirp/tftp.h |    1 +
 2 files changed, 44 insertions(+), 23 deletions(-)
Signature · 1 line
1.7.10.4