Skip to content

Quorum block driver

Benoît Canet qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest11 patches 24 repliesIn review
  2. v7 RFC11 patches 1 replySuperseded
  3. v6 RFC11 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v111 patches2 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.block/Makefile.objs block/quorum.c+55 -01 reply
2/11quorum: Create BDRVQuorumState and BlkDriver and do init.block/quorum.c+25 -01 reply
3/11quorum: Add quorum_aio_writev and its dependencies.block/quorum.c+123 -04 replies
4/11blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.block/blkverify.c include/qemu-common.h util/iov.c+107 -1060 replies
5/11quorum: Add quorum_aio_readv.block/quorum.c+39 -11 reply
6/11quorum: Add quorum mechanism.block/Makefile.objs block/quorum.c configure +2 more+361 -25 replies
7/11quorum: Add quorum_getlength().block/quorum.c+26 -01 reply
8/11quorum: Add quorum_invalidate_cache().block/quorum.c+11 -00 replies
9/11quorum: Add quorum_co_get_block_status.block/quorum.c+67 -01 reply
10/11quorum: Add quorum_co_flush().block/quorum.c+34 -01 reply
11/11quorum: Add quorum_open() and quorum_close().block/quorum.c+338 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [Qemu-devel] [PATCH V9 00/11] Quorum block driver

It must be applied on top of "block: Add BlockDriver.bdrv_check_ext_snapshot."

This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files.
For the reading part the $total files are read at the same time and a vote is done to determine if a qiov version is present $threshold or more times. It then return this majority version to the upper layers.
When i < $threshold versions of the data are returned by the lower layer the quorum is broken and the read return -EIO.

The goal of this patchset is to be turned in a QEMU block filter living just above raw-*.c and below qcow2/qed when the required infrastructure will be done.

Main use of this feature will be people using NFS appliances which can be subjected to bitflip errors.

This patchset can be used to replace blkverify and the out of tree blkmirror.

v9: integrate latests comments from kevin

Benoît Canet (11):
quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.
quorum: Create BDRVQuorumState and BlkDriver and do init.
quorum: Add quorum_aio_writev and its dependencies.
blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from
blkverify.
quorum: Add quorum_aio_readv.
quorum: Add quorum mechanism.
quorum: Add quorum_getlength().
quorum: Add quorum_invalidate_cache().
quorum: Add quorum_co_get_block_status.
quorum: Add quorum_co_flush().
quorum: Add quorum_open() and quorum_close().

 block/Makefile.objs       |    1 +
 block/blkverify.c         |  108 +----
 block/quorum.c            | 1035 +++++++++++++++++++++++++++++++++++++++++++++
 configure                 |   36 ++
 include/monitor/monitor.h |    2 +
 include/qemu-common.h     |    2 +
 monitor.c                 |    2 +
 util/iov.c                |  103 +++++
 8 files changed, 1183 insertions(+), 106 deletions(-)
 create mode 100644 block/quorum.c
Signature · 1 line
1.8.1.2