Skip to content

target-mips: DSP ASE fixes and cleanup

Aurelien Jarno qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 9 repliesIn review
  2. v17 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- patch 1: unchanged
- patch 2: new patch as suggested by Richard Henderson
- patch 3: updated to use insn_flags from DisasContext
- patch 4: unchanged
- patch 5: fix the cast on the return value
- patch 6: fix the cast on the return value
- patch 7: unchanged
- patch 8: unchanged

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8target-mips: fix DSP loads with rd = 0target-mips/translate.c+0 -50 replies
2/8target-mips: copy insn_flags in DisasContexttarget-mips/translate.c+381 -3810 replies
3/8target-mips: generate a reserved instruction exception on CPU without DSPtarget-mips/translate.c+10 -20 replies
4/8target-mips: add unions to access DSP elementstarget-mips/dsp_helper.c+22 -00 replies
5/8target-mips: use DSP unions for binary DSP operatorstarget-mips/dsp_helper.c+116 -2685 replies
6/8target-mips: use DSP unions for unary DSP operatorstarget-mips/dsp_helper.c+42 -821 reply
7/8target-mips: use DSP unions for reduction add instructionstarget-mips/dsp_helper.c+15 -171 reply
8/8target-mips: implement DSP (d)append sub-class with TCGtarget-mips/dsp_helper.c target-mips/helper.h target-mips/translate.c+87 -1260 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric JohnsonRichard Henderson
SeriesR-b
1/8R-b
2/8
3/8
4/8R-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/8] target-mips: DSP ASE fixes and cleanup

This patch series contains some fixes and cleanup following the merge of the DSP ASE patches.

Changes v1 -> v2:
- patch 1: unchanged
- patch 2: new patch as suggested by Richard Henderson
- patch 3: updated to use insn_flags from DisasContext
- patch 4: unchanged
- patch 5: fix the cast on the return value
- patch 6: fix the cast on the return value
- patch 7: unchanged
- patch 8: unchanged

Aurelien Jarno (8):
target-mips: fix DSP loads with rd = 0
target-mips: copy insn_flags in DisasContext
target-mips: generate a reserved instruction exception on CPU without DSP
target-mips: add unions to access DSP elements
target-mips: use DSP unions for binary DSP operators
target-mips: use DSP unions for unary DSP operators
target-mips: use DSP unions for reduction add instructions
target-mips: implement DSP (d)append sub-class with TCG

 target-mips/dsp_helper.c |  623 ++++++++++---------------------
 target-mips/helper.h     |   13 -
 target-mips/translate.c  |  912 ++++++++++++++++++++++++----------------------
 3 files changed, 670 insertions(+), 878 deletions(-)
Signature · 1 line
1.7.10.4