Skip to content

I2C libqos and tmp105 qtest support

Andreas Färber qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 0 repliesNew
  2. v36 patches 0 repliesSuperseded
  3. v27 patches 5 repliesSuperseded

Changes in v4 from the cover letter

* Rebased tmp105 onto already-const TypeInfo.
* Rebased qtest Makefile additions onto second build reorganization.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6libqtest: Prepare I2C libqostests/Makefile tests/libi2c-omap.c tests/libi2c.c +1 more+219 -00 replies
2/6tmp105: Split out I2C message constants from headerhw/tmp105.h hw/tmp105_regs.h+51 -330 replies
3/6tmp105: Fix I2C protocol bughw/tmp105.c+6 -30 replies
4/6tests: Add tmp105 qtest test casetests/Makefile tests/tmp105-test.c+79 -00 replies
5/6tmp105: QOM'ifyhw/tmp105.c hw/tmp105.h+39 -240 replies
6/6tmp105: Add temperature QOM propertyhw/tmp105.c hw/tmp105.h+29 -200 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchAnthony Liguori
1/6R-b
2/6R-b
3/6R-b
4/6
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH for-1.4 v4 0/6] I2C libqos and tmp105 qtest support

Hello Anthony,

Here's another rebased version of $subject. Please review changed bits and apply.

Regards,
Andreas

v3 -> v4:
* Rebased tmp105 onto already-const TypeInfo.
* Rebased qtest Makefile additions onto second build reorganization.

v2 -> v3:
* Alex' tmp105.h patch was applied.
* Rebased onto header reorganization.
* Rebased onto introduction of gcov support.
* Switched order of test case and bugfix to keep make check happy.
* Dropped extra white line and renamed int64_t value -> temp to make patch smaller.

v1 -> v2:
* Factor out libqos API for I2C and an OMAP driver
* Avoid casts by using uint8_t* in API, suggested by Blue
* Ignore SBD bit in omap_i2c driver
* Drop omap_i2c patch clearing SBD
* Incorporate Alex' tmp105.h patch
* Split out tmp105_regs.h for qtest, inspired by rtc-test
* Append replacement for Alex' fix
* Append QOM cleanup and turn setter function into QOM property

Cc Anthony Liguori <[email protected]>
Cc Alex Horn <[email protected]>
Cc Andrzej Zaborowski <[email protected]>
Cc Peter Maydell <[email protected]>

Andreas Färber (6):
libqtest: Prepare I2C libqos
tmp105: Split out I2C message constants from header
tmp105: Fix I2C protocol bug
tests: Add tmp105 qtest test case
tmp105: QOM'ify
tmp105: Add temperature QOM property

 hw/tmp105.c         |   77 ++++++++++++++----------
 hw/tmp105.h         |   64 +++++++-------------
 hw/tmp105_regs.h    |   50 ++++++++++++++++
 tests/Makefile      |    4 ++
 tests/libi2c-omap.c |  166 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/libi2c.c      |   22 +++++++
 tests/libi2c.h      |   30 ++++++++++
 tests/tmp105-test.c |   76 +++++++++++++++++++++++
 8 Dateien geändert, 416 Zeilen hinzugefügt(+), 73 Zeilen entfernt(-)
 create mode 100644 hw/tmp105_regs.h
 create mode 100644 tests/libi2c-omap.c
 create mode 100644 tests/libi2c.c
 create mode 100644 tests/libi2c.h
 create mode 100644 tests/tmp105-test.c
Signature · 1 line
1.7.10.4

Read the cover letter in its thread