Skip to content

em28xx: i2c bug fixes and cleanups

Frank Schäfer linux-media 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesNew
  2. v25 patches 14 repliesSuperseded
  3. v15 patches 9 repliesSuperseded

Changelog from the cover letter

v2: - removed i2c address type/range check from patch 5 as requested by Antti Palosaari
v3: - removed patch 1 (already applied)
- added comment that explains the reasons for the i2c message size restrictions on em28xx devices
- added another patch that fixes eeprom reading with the em2800

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5em28xx: respect the message size constraints for i2c transfersdrivers/media/usb/em28xx/em28xx-i2c.c+18 -260 replies
2/5em28xx: fix two severe bugs in function em2800_i2c_recv_bytes()drivers/media/usb/em28xx/em28xx-i2c.c drivers/media/usb/em28xx/em28xx.h+58 -480 replies
3/5em28xx: fix the i2c adapter functionality flagsdrivers/media/usb/em28xx/em28xx-i2c.c+5 -10 replies
4/5em28xx: fix+improve+unify i2c error handling, debug messages and code commentsdrivers/media/usb/em28xx/em28xx-core.c drivers/media/usb/em28xx/em28xx-i2c.c+89 -320 replies
5/5em28xx: consider the message length limitation of the i2c adapter when reading the eepromdrivers/media/usb/em28xx/em28xx-i2c.c+9 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] em28xx: i2c bug fixes and cleanups

This patch series contains some I2C bug fixes / cleanups / unifications and improvements for the em28xx driver, which I've made while working on adding support for the em25xx/em276x i2c bus B support and playing with the Terratec Cinergy 200 USB which I've got recently.

Patches 1, 2, 3, 5 fix some bugs, patch 4 is a cleanup/unification patch. Patch 2 actually fixes 2 bugs, but separate commits didn't make sense, because more or less the whole function had to be rewritten.

Changelog:
v2: - removed i2c address type/range check from patch 5 as requested by Antti Palosaari
v3: - removed patch 1 (already applied)
- added comment that explains the reasons for the i2c message size restrictions on em28xx devices
- added another patch that fixes eeprom reading with the em2800

Frank Schäfer (5):
em28xx: respect the message size constraints for i2c transfers
em28xx: fix two severe bugs in function em2800_i2c_recv_bytes()
em28xx: fix the i2c adapter functionality flags
em28xx: fix+improve+unify i2c error handling, debug messages and code
comments
em28xx: consider the message length limitation of the i2c adapter
when reading the eeprom

 drivers/media/usb/em28xx/em28xx-core.c |    5 +-
 drivers/media/usb/em28xx/em28xx-i2c.c  |  276 ++++++++++++++++++++------------
 drivers/media/usb/em28xx/em28xx.h      |    2 +-

3 Dateien geändert, 176 Zeilen hinzugefügt(+), 107 Zeilen entfernt(-)

Signature · 1 line
1.7.10.4