Skip to content

staging/fwserial: Address reviewer comments

Peter Hurley lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 0 repliesNew
  2. v20 of 5 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6staging/fwserial: Remove bandwidth limit logicdrivers/staging/fwserial/fwserial.c drivers/staging/fwserial/fwserial.h+6 -120 replies
2/6staging/fwserial: Refer to fw_device as "node"drivers/staging/fwserial/fwserial.c+1 -10 replies
3/6staging/fwserial: Simplify max payload calculationdrivers/staging/fwserial/fwserial.h+2 -20 replies
4/6staging/fwserial: Fold constant MAX_ASYNC_PAYLOADdrivers/staging/fwserial/fwserial.c+1 -20 replies
5/6staging/fwserial: Assume firmware is OHCI-complaintdrivers/staging/fwserial/fwserial.c+7 -20 replies
6/6staging/fwserial: Drop suggestion for helper fn integrationdrivers/staging/fwserial/TODO+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/6] staging/fwserial: Address reviewer comments

Hi Greg,

Here's the delta patches to get from v1 --> v2 of the patch series. Patches 2,3 & 4 are the "sub-patches" from
[PATCH v2 3/6] staging/fwserial: Limit tx/rx to 1394-2008 spec maximum

Peter Hurley (6):
staging/fwserial: Remove bandwidth limit logic staging/fwserial: Refer to fw_device as "node" staging/fwserial: Simplify max payload calculation staging/fwserial: Fold constant MAX_ASYNC_PAYLOAD staging/fwserial: Assume firmware is OHCI-complaint staging/fwserial: Drop suggestion for helper fn integration

 drivers/staging/fwserial/TODO       |  2 --
 drivers/staging/fwserial/fwserial.c | 15 ++++++++-------
 drivers/staging/fwserial/fwserial.h | 17 +++++++----------
 3 files changed, 15 insertions(+), 19 deletions(-)
Signature · 1 line
1.8.1.1