RFC uprobes: return probe implementation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 RFC Latest6 patches 8 repliesIn review
- v3 RFC6 patches 10 repliesSuperseded
- v2 RFC4 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 6 patches | 14 replies | Superseded |
Changes in v4 from the cover letter
- get rid of area->rp_trampoline_vaddr as it always the same as ->vaddr
- preallocate slot, as the first one in xol_add_vma()
- cleanup ->return_uprobes list in uprobe_free_utask(), because the task can exit from inside the ret-probe'd function(s).
- in find_active_uprobe(): Once we inserted "int3" we must ensure that handle_swbp() will be called even if this uprobe goes away. We have the reference but it only protects uprobe itself, it can't protect agains delete_uprobe().
IOW, we must ensure that uprobe_pre_sstep_notifier() can't return 0.
- check, whether utask is not NULL in handle_uretprobe()
? do we want a printk() for this case?
- minor handle_uretprobe() fixups
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | uretprobes: preparation patchinclude/ kernel/ | +9 | 0 replies | |
| 2/6 | uretprobes/x86: hijack return addressarch/ arch/ | +30 | 0 replies | |
| 3/6 | uretprobes: generalize xol_get_insn_slot()kernel/ | +3 | 0 replies | |
| 4/6 | uretprobes: return probe entry, prepare uretprobeinclude/ kernel/ | +68 | 2 replies | |
| 5/6 | uretprobes: invoke return probe handlersarch/ kernel/ | +60 | 4 replies | |
| 6/6 | uretprobes: implemented, thus remove -ENOSYSkernel/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [RFC PATCH v4 0/6] uprobes: return probe implementation
Hello,
RFC v4 uretprobes implementation. I'd be grateful for review. /* Oleg, this one is more quirky than previous, don't beat me. */
These patches extending uprobes by enabling tools, such as perf(trace_event),
set a breakpoint on probed function's return address.
v4:
- get rid of area->rp_trampoline_vaddr as it always the same as ->vaddr
- preallocate slot, as the first one in xol_add_vma()
- cleanup ->return_uprobes list in uprobe_free_utask(), because the task can exit from inside the ret-probe'd function(s).
- in find_active_uprobe(): Once we inserted "int3" we must ensure that handle_swbp() will be called even if this uprobe goes away. We have the reference but it only protects uprobe itself, it can't protect agains delete_uprobe().
IOW, we must ensure that uprobe_pre_sstep_notifier() can't return 0.
- check, whether utask is not NULL in handle_uretprobe()
? do we want a printk() for this case?
- minor handle_uretprobe() fixups
v3 changes:
- removed uretprobe_bypass logic, it will be better to send it as independent patch
- unified xol_get_trampoline_slot() and xol_get_insn_slot()
- protected uprobe with refcounter in prepare_uretprobe()
- uprobe_register() routine fails now, if neither consumer is set
- enclosed implementation into 1/6, 6/6 patches -ENOSYS bits
v2 changes:
- introduced rp_handler(), get rid of return_consumers
- get rid of uretprobe_[un]register()
- introduced arch_uretprobe_get_sp()
- removed uprobe_task->doomed, kill task immediately
- fix arch_uretprobe_hijack_return_addr()'s returns
- address the v1 minor issues
integrated patchset:
http://github.com/arapov/linux-aa/commits/uretprobes_v3
previous implementations:
RFCv3: https://lkml.org/lkml/2013/2/28/148
RFCv2: https://lkml.org/lkml/2013/1/9/157
RFCv1: https://lkml.org/lkml/2012/12/21/133
thanks,
Anton
Anton Arapov (6):
uretprobes: preparation patch uretprobes/x86: hijack return address
uretprobes: generalize xol_get_insn_slot()
uretprobes: return probe entry, prepare uretprobe
uretprobes: invoke return probe handlers
uretprobes: implemented, thus remove -ENOSYS
arch/x86/include/asm/uprobes.h | 6 ++ arch/x86/kernel/uprobes.c | 29 +++++++++ include/linux/uprobes.h | 5 ++ kernel/events/uprobes.c | 134 ++++++++++++++++++++++++++++++++++++++--- 4 files changed, 166 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.1.2