Skip to content

RFC Remove old_portio usage

Hervé Poussineau qemu-devel xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8pc: disable bochs bios debug ports (do not apply!)hw/pc.c+6 -00 replies
2/8xen_platform: do not use old_portio-style callbackshw/xen_platform.c+10 -110 replies
3/8uhci: do not use old_portio-style callbackshw/usb/hcd-uhci.c+33 -101 reply
4/8acpi-piix4: do not use old_portio-style callbackshw/acpi_piix4.c+40 -510 replies
5/8vga/qxl: do not use portio_list_init/portio_list_addhw/qxl.c hw/vga.c+3 -90 replies
6/8isa: use memory regions instead of portio_list_* functionshw/isa-bus.c hw/isa.h+125 -40 replies
7/8ioport: remove now useless portio_list_* functionsioport.c ioport.h+0 -1400 replies
8/8memory: remove old_portio-style callbacks supportmemory.c memory.h+0 -480 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC 0/8] Remove old_portio usage

These proposed patches aim at removing the .old_portio member of MemoryRegionOps structure, and replacing their usage by .read/.write handlers.

Patches 2 to 6 are already ready to be committed. However, patches 7 and 8 depend of patch 1, where a better solution needs to be found.

That way, faked I/O address space can be removed from architectures which don't have it (MIPS, PowerPC...), and commits like a178274efabcbbc5d44805b51def874e47051325 ("PPC: pseries: Remove hack for PIO window") can be reapplied.

Hervé Poussineau (8):
pc: disable bochs bios debug ports (do not apply!)
xen_platform: do not use old_portio-style callbacks
uhci: do not use old_portio-style callbacks
acpi-piix4: do not use old_portio-style callbacks vga/qxl: do not use portio_list_init/portio_list_add
isa: use memory regions instead of portio_list_* functions
ioport: remove now useless portio_list_* functions
memory: remove old_portio-style callbacks support

 hw/acpi_piix4.c   |   91 +++++++++++++++++---------------------
 hw/isa-bus.c      |  127 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 hw/isa.h          |    2 +-
 hw/pc.c           |    6 +++
 hw/qxl.c          |    4 +-
 hw/usb/hcd-uhci.c |   43 +++++++++++++-----
 hw/vga.c          |    8 +---
 hw/xen_platform.c |   21 +++++----
 ioport.c          |  121 --------------------------------------------------
 ioport.h          |   19 --------
 memory.c          |   44 -------------------
 memory.h          |    4 --
 12 files changed, 217 insertions(+), 273 deletions(-)
Signature · 1 line
1.7.10.4