Skip to content

brcm80211: cleanup work

Arend van Spriel linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18brcmsmac: increase timer reference count for new timers onlydrivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c+4 -30 replies
2/18brcmsmac: use perimeter lock in add_interface() callbackdrivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c+2 -00 replies
3/18brcmsmac: allow user-space setting of interface addressdrivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c drivers/net/wireless/brcm80211/brcmsmac/main.c+4 -40 replies
4/18brcmsmac: remove dead codedrivers/net/wireless/brcm80211/brcmsmac/ampdu.c drivers/net/wireless/brcm80211/brcmsmac/scb.h+2 -60 replies
5/18brcmfmac: do not reconfigure refill rx on 0-length packet.drivers/net/wireless/brcm80211/brcmfmac/usb.c+5 -10 replies
6/18brcmfmac: removed deprecated set_bitrate_mask supportdrivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+0 -620 replies
7/18brcmfmac: assure USB dongle firmware is reset upon module unloaddrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c +1 more+27 -10 replies
8/18brcmfmac: define pr_fmt in one placedrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c +6 more+5 -285 replies
9/18brcmfmac: remove rx helper function from bus interfacedrivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c +1 more+13 -160 replies
10/18brcmfmac: remove brcmf_proto_hdrpull() from bus interfacedrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c +3 more+29 -430 replies
11/18brcmfmac: Use dedicated trace level for CDC.drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+24 -250 replies
12/18brcmfmac: remove unused event related definitionsdrivers/net/wireless/brcm80211/brcmfmac/dhd.h+0 -70 replies
13/18brcmfmac: cleanup netdev transmit callbackdrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+13 -90 replies
14/18brcmfmac: remove unnecessary curly braces in dhd_attach()drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+1 -20 replies
15/18brcmfmac: Remove unused caching dongle error.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c+2 -230 replies
16/18brcmfmac: Return correct error on netdev xmit.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+12 -100 replies
17/18brcmfmac: Removing obsolete variables and inline functions.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c+0 -260 replies
18/18brcmfmac: Update init code routines from interface up.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c+15 -240 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchPieter-Paul GiesbertsPiotr HaberArend Van SprielHante Meuleman
1/18R-b R-b R-b
2/18R-b R-b
3/18R-b R-b
4/18R-b R-b R-b
5/18R-b R-b
6/18R-b R-b
7/18R-b R-b
8/18R-b R-b R-b R-b
9/18R-b R-b
10/18R-b R-b
11/18R-b R-b
12/18R-b R-b
13/18R-b R-b
14/18R-b R-b
15/18R-b R-b
16/18R-b R-b
17/18R-b R-b
18/18R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/18] brcm80211: cleanup work

cleanup and rework on both drivers although mostly on brcmfmac.

This series is intended for v3.9 and applies to the master branch of wireless-next.

Arend van Spriel (9):
brcmsmac: use perimeter lock in add_interface() callback
brcmsmac: allow user-space setting of interface address
brcmfmac: assure USB dongle firmware is reset upon module unload
brcmfmac: define pr_fmt in one place
brcmfmac: remove rx helper function from bus interface
brcmfmac: remove brcmf_proto_hdrpull() from bus interface
brcmfmac: remove unused event related definitions
brcmfmac: cleanup netdev transmit callback
brcmfmac: remove unnecessary curly braces in dhd_attach()

Hante Meuleman (7):
brcmfmac: do not reconfigure refill rx on 0-length packet.
brcmfmac: removed deprecated set_bitrate_mask support
brcmfmac: Use dedicated trace level for CDC.
brcmfmac: Remove unused caching dongle error.
brcmfmac: Return correct error on netdev xmit.
brcmfmac: Removing obsolete variables and inline functions.
brcmfmac: Update init code routines from interface up.

Piotr Haber (2):
brcmsmac: increase timer reference count for new timers only
brcmsmac: remove dead code

 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c   |    2 -
 .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |    2 -
 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |   39 ++------
 drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h  |   19 +---
 drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c  |   48 +++-------
 .../net/wireless/brcm80211/brcmfmac/dhd_common.c   |    2 -
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h  |   50 +++++------
 .../net/wireless/brcm80211/brcmfmac/dhd_linux.c    |   90 +++++++++++--------
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |   24 ++---
 .../net/wireless/brcm80211/brcmfmac/sdio_chip.c    |    2 -
 drivers/net/wireless/brcm80211/brcmfmac/usb.c      |   27 ++++--
 .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c  |   94 +++-----------------
 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c    |    7 +-
 .../net/wireless/brcm80211/brcmsmac/mac80211_if.c  |   10 ++-
 drivers/net/wireless/brcm80211/brcmsmac/main.c     |    7 +-
 drivers/net/wireless/brcm80211/brcmsmac/scb.h      |    1 -
 16 files changed, 146 insertions(+), 278 deletions(-)
Signature · 1 line
1.7.10.4