Skip to content

memory: remove old_portio usage

Hervé Poussineau qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 7 repliesIn review
  2. v110 patches 16 repliesApplied

Changes in v2 from the cover letter

- handling of Portio has been moved to ioport.c (instead of isa-bus.c) This prevents creating an ISA bus on machines which don't have one
- added last 4 patches to see benefits of removing old_portio

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8isa: fix documentation of isa_register_portio_listinclude/hw/isa/isa.h+1 -10 replies
2/8memory: handle old_portio accesses in MMIO pathmemory.c+16 -00 replies
3/8ioport: register memory regions for I/O port listsinclude/exec/ioport.h ioport.c+107 -280 replies
4/8memory: remove code dealing with old_portioinclude/exec/memory.h memory.c+0 -640 replies
5/8ioport: reimplement cpu_in/cpu_out using address_space_rwioport.c+7 -760 replies
6/8ppc: simplify access to PReP I/O regionhw/ppc/prep.c+9 -560 replies
7/8PPC: pseries: Remove hack for PIO windowhw/ppc/spapr_pci.c include/hw/pci-host/spapr.h+2 -440 replies
8/8isa_mmio: simplify access to system I/O regionhw/isa/isa_mmio.c+11 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

These proposed patches aim at removing the .old_portio member of MemoryRegionOps structure, and replacing their usage by .read/.write handlers.

That way, faked I/O address space can be removed from architectures which don't have it (MIPS, PowerPC...), and commits like a178274efabcbbc5d44805b51def874e47051325 ("PPC: pseries: Remove hack for PIO window") can be reapplied.

The first 4 patches do the cleanup and remove the old_portio handler in MemoryRegion structure.
The last 4 patches are simplifications, now that Portio handlers can be called from memory core without limitation.

Changes since v1:
- handling of Portio has been moved to ioport.c (instead of isa-bus.c) This prevents creating an ISA bus on machines which don't have one
- added last 4 patches to see benefits of removing old_portio

Alexander Graf (1):
PPC: pseries: Remove hack for PIO window

Hervé Poussineau (7):
isa: fix documentation of isa_register_portio_list
memory: handle old_portio accesses in MMIO path
ioport: register memory regions for I/O port lists
memory: remove code dealing with old_portio
ioport: reimplement cpu_in/cpu_out using address_space_rw
ppc: simplify access to PReP I/O region
isa_mmio: simplify access to system I/O region

 hw/isa/isa_mmio.c           |   42 +++------
 hw/ppc/prep.c               |   65 ++-----------
 hw/ppc/spapr_pci.c          |   44 +--------
 include/exec/ioport.h       |    3 +-
 include/exec/memory.h       |    4 -
 include/hw/isa/isa.h        |    2 +-
 include/hw/pci-host/spapr.h |    2 +-
 ioport.c                    |  215 ++++++++++++++++++++++---------------------
 memory.c                    |   44 ---------
 9 files changed, 137 insertions(+), 284 deletions(-)
Signature · 1 line
1.7.10.4